-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix queue populator shared metrics #2612
base: development/9.0
Are you sure you want to change the base?
Conversation
Hello kerkesni,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 2 files with indirect coverage changes
@@ Coverage Diff @@
## development/9.0 #2612 +/- ##
===================================================
+ Coverage 71.11% 71.39% +0.27%
===================================================
Files 201 201
Lines 13334 13338 +4
===================================================
+ Hits 9483 9522 +39
+ Misses 3841 3806 -35
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. |
Some queue populator metrics are shared between all extensions and not specific to replication. Issue: BB-527
Queue Populator can be used for a single or multiple extensions at once. Currently the 'origin' label in the metrics is always set to "replication" which is not always true, we change this to make it hold the list of loaded extensions in the current queue populator instance. Issue: BB-527
61a5c13
to
34de938
Compare
oras was removed from from Ubuntu 24.04 GitHub runner images Issue: BB-527
3b937df
to
b2eeb64
Compare
@@ -27,6 +27,13 @@ jobs: | |||
username: ${{ github.repository_owner }} | |||
password: ${{ github.token }} | |||
|
|||
- name: Install Oras |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed, please rebase...
@@ -45,6 +46,7 @@ class BucketFileLogReader extends LogReader { | |||
|
|||
getMetricLabels() { | |||
return { | |||
origin: this._extensionNames, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we not "join" the strings in the array? (here or maybe better in the constructor)
this._extensionNames.join(',')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be nice to document somewhere what "origin" really is : i.e. not the pod/process which generated the metric, but the kind of workflow/process from which the 'processing' was triggered... (i.e. so that we have replication count either from "replication" rules and "transition")
s3_backbeat_populator
instead ofs3_replication
Issue: BB-527