-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: chore: updates Node to v16 (BKTCLT-3) #226
base: development/7.4
Are you sure you want to change the base?
WIP: chore: updates Node to v16 (BKTCLT-3) #226
Conversation
Hello george-the-wizard,My role is to assist you with the merge of this Status report is not available. |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/8.1/feature/BKTCLT-3/upgrade-to-node16 origin/development/8.1
$ git merge origin/w/7.10/feature/BKTCLT-3/upgrade-to-node16
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/8.1/feature/BKTCLT-3/upgrade-to-node16 |
@bert-e reset |
Reset completeI have successfully deleted this pull request's integration branches. |
@@ -0,0 +1,8 @@ | |||
module.exports = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should add prettier at the same time as a node upgrade, maybe a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. @george-the-wizard please focus on upgrading the code to be compatible with Node 16 and any additional work can be followed up later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miniscruff @rahulreddy I needed it in order to be able to troubleshoot the issues efficiently, I will revert the related changes after it builds flawlessly - thx
No description provided.