Skip to content

Commit

Permalink
add correct border around chart
Browse files Browse the repository at this point in the history
  • Loading branch information
JeanMarcMilletScality committed Feb 23, 2024
1 parent ed1796a commit 1ff451c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 10 deletions.
6 changes: 3 additions & 3 deletions src/lib/components/vegachartv2/VegaChartV2.component.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ function VegaChartInternal(
const currentTheme = useTheme();
const themeConfig = {
config: {
background: currentTheme.backgroundLevel1,
background: 'transparent',
axis: {
labelColor: currentTheme.textSecondary,
titleColor: currentTheme.textSecondary,
Expand All @@ -87,7 +87,8 @@ function VegaChartInternal(
font: 'Lato',
},
view: {
stroke: 'transparent',
stroke: currentTheme.border,
strokeWidth: 0.5,
fill: currentTheme.backgroundLevel1,
},
// the headers provide a title and labels for faceted plots.
Expand Down Expand Up @@ -265,7 +266,6 @@ function VegaChartInternal(
ref={vegaDOMInstance}
style={{
width: '100%',
border: `${currentTheme.backgroundLevel3} 1px solid`,
}}
>
<VegaTooltipTheme />
Expand Down
8 changes: 1 addition & 7 deletions stories/barchart.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,7 @@ export default {
title: 'Components/Data Display/Charts/BarChart',
component: BarChart,
decorators: [
(story: Component) => (
<Wrapper
style={{ minHeight: '30vh', padding: '3rem', backgroundColor: 'white' }}
>
<SyncedCursorCharts>{story()}</SyncedCursorCharts>
</Wrapper>
),
(story: Component) => <SyncedCursorCharts>{story()}</SyncedCursorCharts>,
],
argTypes: {
data: {
Expand Down

0 comments on commit 1ff451c

Please sign in to comment.