fix typing issues with useMutationsHandler

scality · Oct 25, 2023 · b64eb47 · b64eb47
1 parent 52ef758
commit b64eb47
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/lib/components/toast/useMutationsHandler.test.tsx b/src/lib/components/toast/useMutationsHandler.test.tsx
@@ -10,7 +10,7 @@ const mockUseToast = useToast as jest.MockedFunction<typeof useToast>;
 
 const mutationResultMock = {
   context: undefined,
-  data: [],
+  data: ['mockData'],
   failureCount: 0,
   error: null,
   mutate: jest.fn(),
@@ -56,7 +56,7 @@ describe('useMutationsHandler', () => {
       },
       name: 'mutation3',
     },
-  ];
+  ] as const;
 
   const messageDescriptionBuilder = jest.fn(() => 'message');
 
@@ -129,7 +129,7 @@ describe('useMutationsHandler', () => {
         },
         name: 'mutation4',
       },
-    ];
+    ] as const;
 
     const { waitFor } = renderHook(() =>
       useMutationsHandler({

diff --git a/src/lib/components/toast/useMutationsHandler.ts b/src/lib/components/toast/useMutationsHandler.ts
@@ -43,9 +43,9 @@ declare type MutationsResults<
   ? [...Result, GetResults<Head>]
   : T extends [infer Head, ...infer Tail]
   ? MutationsResults<[...Tail], [...Result, GetResults<Head>], [...Depth, 1]>
-  : T extends MutationConfig<MinimalMutationResult<infer TData, infer TError>>[]
-  ? MutationConfig<MinimalMutationResult<TData, TError>>[]
-  : MutationConfig<MinimalMutationResult<unknown, unknown>>[];
+  : unknown[] extends T
+  ? T
+  : never;
 
 enum DescriptionBuilderStatus {
   Success = 'success',
@@ -120,7 +120,7 @@ export const useMutationsHandler = <
   const mutations = [
     mainMutation,
     ...(dependantMutations ? dependantMutations : []),
-  ];
+  ] as MutationConfig<MinimalMutationResult<unknown, unknown>>[];
 
   const handleMutationsCompletion = useCallback(async () => {
     const results = await Promise.all(mutations.map((m) => m.mutation));