feature: Toast component #628

hervedombya · 2023-09-11T08:22:57Z

Component:
'Toast'

Description:
Toast inform users of a process that an app has performed or will perform. They appear temporarily, towards the top of the screen. They shouldn't interrupt the user experience, and they don't require user input to disappear.

Design:

Breaking Changes:

[] Breaking Changes

Closes: #ISSUE_NUMBER

bert-e · 2023-09-11T08:23:00Z

Hello hervedombya,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2023-09-11T08:23:10Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2023-09-12T15:10:25Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2023-09-13T09:36:44Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2023-09-13T09:42:27Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2023-09-18T09:07:27Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2023-09-20T11:24:16Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2023-10-04T12:44:42Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2023-10-05T16:15:30Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

JBWatenbergScality · 2023-10-13T14:03:41Z

src/lib/components/toast/Toast.component.tsx

+  const color = useGetBackgroundColor(status);
+  const iconName = defaultIconName(status);
+
+  return <Icon name={iconName} color={color as IconColor} />;


Why do we need to cast the IconColor type here ? Is this type not accurate ? maybe we can update it if so 🤔

IconColor type is keyof typeof theme but actually Typescript considers a variable theme.statusHealthy as a string

src/lib/components/toast/Toast.component.tsx

src/lib/components/toast/ToastPositionHelpers.ts

src/lib/components/toast/ToastProgressBar.tsx

src/lib/components/toast/useMutationsHandler.test.tsx

src/lib/components/toast/Toast.component.tsx

bert-e · 2023-10-13T14:41:19Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2023-10-16T09:38:49Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2023-10-18T09:21:17Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

fix dependencies fix framer-motion fix storybook webpack update framer-motion downgrade framer-motion modify toast styles modify export cancel some exports update toast fix navbar issue add useMutationsHandler in core-ui review fixes minor fixes fix theme issue fix generic type try new generic types fix generic modify type fix type typescript wizard fix mutationconfig update mutation fix unknown minor fixes useMutationsHandler works fire !! fix css color fix toastprovider modify toastProps modify rgbacolor fix description builder minor fixes duration progress bar

hervedombya · 2023-10-20T12:31:02Z

/approve

bert-e · 2023-10-20T12:31:10Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/1.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2023-10-20T12:31:16Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/1.0

Please check the status of the associated issue ARTESCA-9182.

Goodbye hervedombya.

hervedombya force-pushed the feature/ARTESCA-9182-Toast-Component branch 2 times, most recently from 8433c43 to 5ebbd99 Compare September 12, 2023 15:38

hervedombya force-pushed the feature/ARTESCA-9182-Toast-Component branch from 7928087 to 575d5d6 Compare September 13, 2023 09:40

hervedombya force-pushed the feature/ARTESCA-9182-Toast-Component branch 2 times, most recently from e29886a to 0b87754 Compare September 13, 2023 14:48

hervedombya force-pushed the feature/ARTESCA-9182-Toast-Component branch 2 times, most recently from 34663a9 to 0782c17 Compare September 18, 2023 12:36

hervedombya force-pushed the feature/ARTESCA-9182-Toast-Component branch from 2f8e107 to 55996db Compare September 20, 2023 11:24

hervedombya force-pushed the feature/ARTESCA-9182-Toast-Component branch from 110dc2f to b4d6888 Compare October 4, 2023 12:45

hervedombya force-pushed the feature/ARTESCA-9182-Toast-Component branch from 3ac52bd to f27d07d Compare October 5, 2023 16:16

JBWatenbergScality reviewed Oct 13, 2023

View reviewed changes

hervedombya force-pushed the feature/ARTESCA-9182-Toast-Component branch 2 times, most recently from 4f76026 to 11c5c0f Compare October 13, 2023 16:13

hervedombya force-pushed the feature/ARTESCA-9182-Toast-Component branch 5 times, most recently from 10470ee to ac6e608 Compare October 16, 2023 13:24

hervedombya force-pushed the feature/ARTESCA-9182-Toast-Component branch 7 times, most recently from 4a78ba2 to 99ac811 Compare October 20, 2023 12:21

hervedombya force-pushed the feature/ARTESCA-9182-Toast-Component branch from 9ffd5ab to 5958906 Compare October 20, 2023 12:28

JBWatenbergScality approved these changes Oct 20, 2023

View reviewed changes

bert-e merged commit 5958906 into development/1.0 Oct 20, 2023
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: Toast component #628

feature: Toast component #628

hervedombya commented Sep 11, 2023 •

edited

Loading

bert-e commented Sep 11, 2023

bert-e commented Sep 11, 2023

bert-e commented Sep 12, 2023

bert-e commented Sep 13, 2023

bert-e commented Sep 13, 2023

bert-e commented Sep 18, 2023

bert-e commented Sep 20, 2023

bert-e commented Oct 4, 2023

bert-e commented Oct 5, 2023

JBWatenbergScality Oct 13, 2023

hervedombya Oct 13, 2023

bert-e commented Oct 13, 2023

bert-e commented Oct 16, 2023

bert-e commented Oct 18, 2023

hervedombya commented Oct 20, 2023

bert-e commented Oct 20, 2023

bert-e commented Oct 20, 2023

feature: Toast component #628

feature: Toast component #628

Conversation

hervedombya commented Sep 11, 2023 • edited Loading

bert-e commented Sep 11, 2023

Hello hervedombya,

bert-e commented Sep 11, 2023

Waiting for approval

bert-e commented Sep 12, 2023

Waiting for approval

bert-e commented Sep 13, 2023

Waiting for approval

bert-e commented Sep 13, 2023

Waiting for approval

bert-e commented Sep 18, 2023

Waiting for approval

bert-e commented Sep 20, 2023

Waiting for approval

bert-e commented Oct 4, 2023

Waiting for approval

bert-e commented Oct 5, 2023

Waiting for approval

JBWatenbergScality Oct 13, 2023

Choose a reason for hiding this comment

hervedombya Oct 13, 2023

Choose a reason for hiding this comment

bert-e commented Oct 13, 2023

Waiting for approval

bert-e commented Oct 16, 2023

Waiting for approval

bert-e commented Oct 18, 2023

Waiting for approval

hervedombya commented Oct 20, 2023

bert-e commented Oct 20, 2023

In the queue

bert-e commented Oct 20, 2023

hervedombya commented Sep 11, 2023 •

edited

Loading