Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/add controls icons objects #648

Merged
merged 21 commits into from
Nov 20, 2023
Merged

Improvement/add controls icons objects #648

merged 21 commits into from
Nov 20, 2023

Conversation

JeanMarcMilletScality
Copy link
Contributor

Component:

Description:

Design:

Breaking Changes:

  • [] Breaking Changes

Closes: #ISSUE_NUMBER

JeanMarcMilletScality and others added 19 commits November 20, 2023 11:51
@JeanMarcMilletScality
add global config for color control in preview
d1fb7ac
@JeanMarcMilletScality
change tabsv2 story, add control and divide in multiple stories with …
85d8c94 
…a default
@JeanMarcMilletScality
change icons to iconOptions name and add export
53c6efd
@JeanMarcMilletScality
change tooltip type in buttonv2 to omit children
d9224d4
@JeanMarcMilletScality
add control file with argTypes and options control use in multiple st…
8789807 
…ories,update chips, constrainedText and tooltip. Add better control on buttonv2 for tooltip : add new args to enable the control of the tooltip
@JeanMarcMilletScality
add variants and sizes options in control, update banner.stories and …
ecbc50a 
…change render of dropdown.stories to add control over icon
@JeanMarcMilletScality
update storybook to 7.5.3
8fbc9f3
@JeanMarcMilletScality
add color name for presetColor in preview
b175eac
@JeanMarcMilletScality
add controls over layout and add icon control for form stories
c4d62d1
@JeanMarcMilletScality
change @types/react version
3391625
@JeanMarcMilletScality
dropdown story change icon with icon name
9d4b132
@JeanMarcMilletScality
add color control for Icon
a68b0e5
@JeanMarcMilletScality
Form stories : disable layout control and add condition for icon control
0e1eba6
@JeanMarcMilletScality
change modal to use useArgs instead of useState in Table
77d505f
@JeanMarcMilletScality
add icon control
1ecafa9
@JeanMarcMilletScality
add description to statuswrapper and disabled children control
78584f5
@JeanMarcMilletScality
change useState for useArgs and add type
f38fbb6
@JeanMarcMilletScality
add argtype of icon in controls for reuse
eb78012
@JeanMarcMilletScality
add a localeArgType for errorpages
6c4b399
@bert-e
Copy link
Contributor

bert-e commented Nov 20, 2023

Hello jeanmarcmilletscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 20, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

JBWatenbergScality
JBWatenbergScality reviewed Nov 20, 2023
View reviewed changes
.storybook/preview.js Outdated Show resolved Hide resolved
stories/form.stories.tsx Show resolved Hide resolved
stories/modal.stories.tsx Outdated Show resolved Hide resolved
JeanMarcMilletScality and others added 2 commits November 20, 2023 14:44
@JeanMarcMilletScality @JBWatenbergScality
Update .storybook/preview.js
6c554de 
Co-authored-by: JBWatenbergScality <[email protected]>
@JeanMarcMilletScality @JBWatenbergScality
Update stories/modal.stories.tsx
83912c7 
Co-authored-by: JBWatenbergScality <[email protected]>
JBWatenbergScality
JBWatenbergScality approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@JBWatenbergScality JBWatenbergScality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@bert-e
Copy link
Contributor

bert-e commented Nov 20, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JeanMarcMilletScality
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Nov 20, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/1.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Nov 20, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.0

Please check the status of the associated issue None.

Goodbye jeanmarcmilletscality.

@bert-e bert-e merged commit 83912c7 into development/1.0 Nov 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBWatenbergScality JBWatenbergScality JBWatenbergScality approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeanMarcMilletScality @bert-e @JBWatenbergScality