Fix/dropdown component and navbar bottom line #800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
momodaadaa99
requested review from
MonPote,
JBWatenbergScality and
JeanMarcMilletScality
JBWatenbergScality
changed the base branch from
development/1.0
to
improvement/status-icon-component
momodaadaa99
force-pushed
the
fix/dropdown-component-and-navbar-bottom-line
branch
from
24d92a3 to
d160dde
Compare
JBWatenbergScality
approved these changes
Nov 20, 2024
| @@ -109,19 +113,30 @@ function Dropdown({ | |||
| items, | |||
| itemToString: (item) => item?.label || '', | |||
| }); | |||
|
|
|||
| const { refs, floatingStyles } = useFloating({ | |||
| // open: isOpen, | |||
|
/approve |
Base automatically changed from
improvement/status-icon-component
to
development/1.0
November 21, 2024 13:56
|
/status |
momodaadaa99
deleted the
fix/dropdown-component-and-navbar-bottom-line
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes include adding new dependencies and refactoring the dropdown component to use
@floating-uiso that it fixes the dropdown problem and add automatic position of the dropdown in case of edges.Dependencies:
@floating-ui/reactto the dependencies inpackage.json.Dropdown Component Enhancements:
Dropdown.component.tsxto use@floating-uifor positioning and interactions.Additional Changes:
Navbar.component.tsxto fix the difference in height in navbar when there is a dropdown.