COSI-39: add-default-case-for-service

scality · Dec 6, 2024 · 32be7c3 · 32be7c3
1 parent de19b1f
commit 32be7c3
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/pkg/driver/provisioner_server_impl.go b/pkg/driver/provisioner_server_impl.go
@@ -177,6 +177,9 @@ func initializeObjectStorageClient(ctx context.Context, clientset kubernetes.Int
 			return nil, nil, status.Error(codes.Internal, "failed to initialize IAM client")
 		}
 		klog.V(3).InfoS("Successfully initialized IAM client", "endpoint", storageClientParameters.Endpoint)
+	default:
+		klog.ErrorS(nil, "Unsupported object storage provider service", "service", service)
+		return nil, nil, status.Error(codes.Internal, "unsupported object storage provider service")
 	}
 	return client, storageClientParameters, nil
 }

diff --git a/pkg/driver/provisioner_server_impl_test.go b/pkg/driver/provisioner_server_impl_test.go
@@ -339,6 +339,19 @@ var _ = Describe("initializeObjectStorageClient", Ordered, func() {
 		Expect(s3Params.Region).To(Equal("us-west-2"))
 	})
 
+	It("should return InvalidArgument error for unsupported object storage provider service", func() {
+		_, err := clientset.CoreV1().Secrets("test-namespace").Create(ctx, secret, metav1.CreateOptions{})
+		Expect(err).To(BeNil())
+
+		client, params, err := driver.InitializeClient(ctx, clientset, parameters, "UnsupportedService")
+
+		Expect(client).To(BeNil())
+		Expect(params).To(BeNil())
+		Expect(err).To(HaveOccurred())
+		Expect(status.Code(err)).To(Equal(codes.Internal))
+		Expect(err.Error()).To(ContainSubstring("unsupported object storage provider service"))
+	})
+
 	It("should return error when FetchSecretInformation fails", func() {
 		delete(parameters, "objectStorageSecretName")