Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COSI-79: Allow end-users to create buckets and access from any namespace #120

Merged
merged 9 commits into from
Jan 23, 2025

Conversation

anurag4DSB
Copy link
Collaborator

@anurag4DSB anurag4DSB commented Jan 21, 2025

End users can create buckets and access from any namespace

  • I removed namespace from all CRs as we are not bound by namespace but by permissions for the COSI driver.
  • Updated docs, to ensure we do not have such a requirement
  • Some CI improvements for bugs and added E2E tests for helm as well (change of decision earlier)
  • Updated both Kustomize deployment and helm charts with new permissions for COSI side car

Next PR: Make helm charts more extensible for users by adding everything to values.yaml. Part of this PR is a first step towards adding reliable e2e test for helm.

@anurag4DSB anurag4DSB changed the title Bugfix | COSI-79: fix role permissions Bugfix | COSI-79: fix role permissions for kustomize Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.47%. Comparing base (1ba6548) to head (908c8ce).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
pkg/driver/provisioner_server_impl.go 97.64% <100.00%> (ø)
Components Coverage Δ
🏠 Main Package ∅ <ø> (∅)
🚗 Driver Package 92.22% <100.00%> (ø)
📡 gRPC Factory Package 82.35% <ø> (ø)
🔐 IAM Client Package 98.17% <ø> (ø)
🌐 S3 Client Package 94.33% <ø> (ø)
🔧 Util Package 100.00% <ø> (ø)
🔖 Constants Package ∅ <ø> (∅)
@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   92.47%   92.47%           
=======================================
  Files          11       11           
  Lines         771      771           
=======================================
  Hits          713      713           
  Misses         49       49           
  Partials        9        9           

@anurag4DSB anurag4DSB force-pushed the bugfix/COSI-79-fix-role-permissions branch from 54b8711 to 34258c9 Compare January 21, 2025 22:11
@anurag4DSB anurag4DSB force-pushed the bugfix/COSI-79-fix-role-permissions branch from 34258c9 to ef6408f Compare January 21, 2025 22:13
@anurag4DSB anurag4DSB changed the title Bugfix | COSI-79: fix role permissions for kustomize Bugfix | COSI-79: fix role permissions for deployments and e2e tests improvement Jan 21, 2025
@anurag4DSB anurag4DSB changed the title Bugfix | COSI-79: fix role permissions for deployments and e2e tests improvement Bugfix | COSI-79: Allow end-users to create buckets and access from any namespace Jan 21, 2025
@anurag4DSB anurag4DSB changed the title Bugfix | COSI-79: Allow end-users to create buckets and access from any namespace COSI-79: Allow end-users to create buckets and access from any namespace Jan 21, 2025
@anurag4DSB anurag4DSB marked this pull request as ready for review January 21, 2025 22:20
@anurag4DSB anurag4DSB requested a review from dvasilas January 22, 2025 16:16
@anurag4DSB anurag4DSB force-pushed the bugfix/COSI-79-fix-role-permissions branch from 695592a to 908c8ce Compare January 23, 2025 09:13
@anurag4DSB anurag4DSB merged commit 30daef1 into main Jan 23, 2025
8 checks passed
@anurag4DSB anurag4DSB deleted the bugfix/COSI-79-fix-role-permissions branch January 23, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants