-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COSI-79: Allow end-users to create buckets and access from any namespace #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anurag4DSB
changed the title
Bugfix | COSI-79: fix role permissions
Bugfix | COSI-79: fix role permissions for kustomize
Jan 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
@@ Coverage Diff @@
## main #120 +/- ##
=======================================
Coverage 92.47% 92.47%
=======================================
Files 11 11
Lines 771 771
=======================================
Hits 713 713
Misses 49 49
Partials 9 9 |
anurag4DSB
force-pushed
the
bugfix/COSI-79-fix-role-permissions
branch
from
January 21, 2025 22:11
54b8711
to
34258c9
Compare
anurag4DSB
force-pushed
the
bugfix/COSI-79-fix-role-permissions
branch
from
January 21, 2025 22:13
34258c9
to
ef6408f
Compare
anurag4DSB
changed the title
Bugfix | COSI-79: fix role permissions for kustomize
Bugfix | COSI-79: fix role permissions for deployments and e2e tests improvement
Jan 21, 2025
anurag4DSB
changed the title
Bugfix | COSI-79: fix role permissions for deployments and e2e tests improvement
Bugfix | COSI-79: Allow end-users to create buckets and access from any namespace
Jan 21, 2025
anurag4DSB
changed the title
Bugfix | COSI-79: Allow end-users to create buckets and access from any namespace
COSI-79: Allow end-users to create buckets and access from any namespace
Jan 21, 2025
dvasilas
reviewed
Jan 22, 2025
dvasilas
approved these changes
Jan 22, 2025
BourgoisMickael
approved these changes
Jan 22, 2025
anurag4DSB
force-pushed
the
bugfix/COSI-79-fix-role-permissions
branch
from
January 23, 2025 09:13
695592a
to
908c8ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End users can create buckets and access from any namespace
Next PR: Make helm charts more extensible for users by adding everything to
values.yaml
. Part of this PR is a first step towards adding reliable e2e test for helm.