Define a public API #228
Merged
Define a public API #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP: I still need to write a short example to illustrate how to use the API (and to ensure that what is exported by |
vrancurel
approved these changes
Aug 3, 2018
|
Ready to merge once I get another approval. The example will be done in another PR. |
lamphamsy
requested changes
Aug 13, 2018
src/gf_ext.h
Outdated
| @@ -33,6 +33,7 @@ | |||
|
|
|||
| #include "arith.h" | |||
| #include "gf_base.h" | |||
| #include "polynomial.h" | |||
There was a problem hiding this comment.
This file would be removed?
There was a problem hiding this comment.
Yes, I'll do it during the rebase
`quadiron.h` is the public header, as such it should only contains/expose the public interface of the library (and not everything, as that was the case). Refs: scality#160
slaperche-scality
force-pushed
the
ft/public_api
branch
from
c87274a to
b62df0b
Compare
lamphamsy
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quadiron.his the public header, as such it should onlycontains/expose the public interface of the library (and not everything,
as that was the case).
Refs: #160