PTFE-782 Add synchronisation method #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #438 +/- ##
===========================================
- Coverage 83.71% 66.69% -17.02%
===========================================
Files 31 31
Lines 1136 1144 +8
===========================================
- Hits 951 763 -188
- Misses 185 381 +196
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tcarmet
requested changes
Sep 13, 2023
Co-authored-by: Thomas Carmet <[email protected]>
tcarmet
reviewed
Sep 14, 2023
Now generating datetime with utc as timezone. Using `datetime.now(timezone.utc)` instead of `datetime.utcnow()` as with `utcnow` the `tzinfo` remains `None` and is not able to compare datetimes that comes from GitHub's API which explicitly contain offset information.
MartinS926
force-pushed
the
bugfix/PTFE-782-Check-github-group-existence
branch
from
6c97031 to
92f54d9
Compare
tcarmet
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.