Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTFE-742 cannot store redhat password as secretstr #452

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Oct 3, 2023

var of type SecretStr are being stored as ***** in redis with redis-om. Leaving us unable to retrieve the proper password when the group is retrieved from the database and not from the settings configuration in the code.

Now defining the var as str until we find a proper solution to the issue.

@tcarmet tcarmet requested a review from a team as a code owner October 3, 2023 21:32
@tcarmet tcarmet force-pushed the feature/PTFE-742-redhat-password branch from afe3e20 to 715f4a9 Compare October 3, 2023 21:33
@codecov-commenter
Copy link

Codecov Report

Merging #452 (715f4a9) into main (cfee242) will decrease coverage by 16.88%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #452       +/-   ##
===========================================
- Coverage   83.56%   66.69%   -16.88%     
===========================================
  Files          31       31               
  Lines        1144     1144               
===========================================
- Hits          956      763      -193     
- Misses        188      381      +193     
Flag Coverage Δ
api 66.69% <100.00%> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
runner_manager/models/backend.py 79.78% <100.00%> (-20.22%) ⬇️

... and 9 files with indirect coverage changes

@tcarmet tcarmet merged commit aa047e8 into main Oct 3, 2023
12 checks passed
@tcarmet tcarmet deleted the feature/PTFE-742-redhat-password branch October 3, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants