Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTFE-1041 review gcloud backend #457

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Oct 6, 2023

No description provided.

@tcarmet tcarmet changed the title feature/PTFE 1041 review gcloud backend PTFE-1041 review gcloud backend Oct 6, 2023
@tcarmet tcarmet force-pushed the feature/PTFE-1041-review-gcloud-backend branch 2 times, most recently from cdeda39 to a7234aa Compare October 6, 2023 16:52
@tcarmet tcarmet marked this pull request as ready for review October 6, 2023 17:11
@tcarmet tcarmet requested a review from a team as a code owner October 6, 2023 17:11
Copy link
Contributor

@nootal nootal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tcarmet tcarmet force-pushed the feature/PTFE-1041-review-gcloud-backend branch from a7234aa to e66e43b Compare October 6, 2023 21:49
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

Merging #457 (6a129f5) into main (7f57bf2) will increase coverage by 1.37%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
+ Coverage   83.92%   85.30%   +1.37%     
==========================================
  Files          31       31              
  Lines        1151     1143       -8     
==========================================
+ Hits          966      975       +9     
+ Misses        185      168      -17     
Flag Coverage Δ
api 67.01% <41.66%> (+0.37%) ⬆️
unit 70.60% <94.44%> (+1.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
runner_manager/models/backend.py 100.00% <100.00%> (ø)
runner_manager/backend/gcloud.py 52.10% <94.28%> (+21.91%) ⬆️

@tcarmet tcarmet force-pushed the feature/PTFE-1041-review-gcloud-backend branch from e66e43b to 6507e22 Compare October 6, 2023 21:56
@tcarmet tcarmet force-pushed the feature/PTFE-1041-review-gcloud-backend branch from 6507e22 to 6a129f5 Compare October 6, 2023 22:18
@tcarmet tcarmet merged commit 5a24935 into main Oct 6, 2023
12 checks passed
@tcarmet tcarmet deleted the feature/PTFE-1041-review-gcloud-backend branch October 6, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants