Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgotten brackets when interpreting runner as str #462

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Oct 13, 2023

No description provided.

@tcarmet tcarmet requested a review from a team as a code owner October 13, 2023 21:05
@codecov-commenter
Copy link

Codecov Report

Merging #462 (6538fad) into main (c78455b) will decrease coverage by 18.55%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main     #462       +/-   ##
===========================================
- Coverage   85.00%   66.46%   -18.55%     
===========================================
  Files          31       31               
  Lines        1154     1154               
===========================================
- Hits          981      767      -214     
- Misses        173      387      +214     
Flag Coverage Δ
api 66.46% <0.00%> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
runner_manager/models/runner.py 72.63% <0.00%> (-26.32%) ⬇️

... and 10 files with indirect coverage changes

@tcarmet tcarmet merged commit 7ce9837 into main Oct 16, 2023
12 checks passed
@tcarmet tcarmet deleted the bugfix/forgotten-brackets-runner-str branch October 16, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants