poetry: add auth-app extra to githubkit #552
Conversation
There was a problem hiding this comment.
Hello @harryfinbow and thank you for your contribution!
Indeed we ended up not using yet the app authentication method and forgot to install the extra package.
The changes LGTM therefore approving the PR.
Won't be able to merge as is though as I see some CI builds are currently failing, I'll have a proper look at it next week to see if I can help move this change forward.
Cheers! And thanks again ❤️
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
===========================================
+ Coverage 67.71% 85.96% +18.24%
===========================================
Files 31 31
Lines 1211 1211
===========================================
+ Hits 820 1041 +221
+ Misses 391 170 -221
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
To help move #552 forward, which is currently facing an issue with the `crontab` package when running `poetry install` within a docker container: - Upgrading poetry version to 1.7.1 - Upgrade setuptools to 69.2.0
|
Was able to get a successful build but had failures due to the fact that PR coming from open source contributions do not have permissions to push on ghcr under the ghcr.io/scality/runnner-manager namespace: Which is fine and given the workflow configuration, expected. So we are good to merge 🚀 Thanks again for your contribution @harryfinbow! |
Using GitHub App authentication causes the worker to crash on startup with following error:
RuntimeError: JWT support for GitHub APP should be installed with 'pip install githubkit[auth-app]'Adding the
auth-appextra to thegithubkitPython package fixes this by allowing the worker to authenticate to GitHub using both token and app auth.