Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(poetry): error in devcontainer command #571

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

lewismiddleton
Copy link
Contributor

Use the --with option from poetry install to install dependency groups instead of --group.

This fixes an error shown on VSCode startup when using the devcontainer:

Running the postCreateCommand from devcontainer.json...

[98026 ms] Start: Run in container: /bin/sh -c poetry install --no-interaction --no-ansi --no-root --group=docs --group=dev
Creating virtualenv runner-manager in /workspaces/runner-manager/.venv

The option "--group" does not exist
[101878 ms] postCreateCommand failed with exit code 1. Skipping any further user-provided commands.
Done. Press any key to close the terminal.

Fix an error in the devcontainer `postCreateCommand`.

`poetry install` is using the wrong flag for dependency groups.
@lewismiddleton lewismiddleton requested a review from a team as a code owner April 3, 2024 17:21
Copy link
Contributor

@tcarmet tcarmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! Thanks for making the appropriate change!

@tcarmet tcarmet merged commit da4ad9d into scality:main Apr 3, 2024
9 of 11 checks passed
@lewismiddleton lewismiddleton deleted the devcontainer branch September 23, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants