Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to list method on aws and gcp #583

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Apr 19, 2024

No description provided.

@tcarmet tcarmet requested a review from a team as a code owner April 19, 2024 21:46
@tcarmet tcarmet changed the title feature/improvements to backend list method Improvements to list method on aws and gcp Apr 19, 2024
@tcarmet tcarmet force-pushed the feature/improvements-to-backend-list-method branch from 3ce6f51 to 9f52b0a Compare April 19, 2024 21:47
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 85.98%. Comparing base (a8d6d33) to head (9f52b0a).

Files Patch % Lines
runner_manager/backend/aws.py 20.00% 4 Missing ⚠️
runner_manager/backend/gcloud.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
- Coverage   86.11%   85.98%   -0.13%     
==========================================
  Files          31       31              
  Lines        1246     1249       +3     
==========================================
+ Hits         1073     1074       +1     
- Misses        173      175       +2     
Flag Coverage Δ
api 66.61% <20.00%> (-0.09%) ⬇️
unit 71.33% <20.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nootal nootal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to understand if it's going to be better or worst, but i'll approve :p

@tcarmet tcarmet merged commit 98968a4 into main Apr 22, 2024
12 checks passed
@tcarmet tcarmet deleted the feature/improvements-to-backend-list-method branch April 22, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants