Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTFE-1798 handling errors of no such index #617

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Jun 3, 2024

If the redis instance happens to reboot during the runtime of the runner manager, redis will need for the Migrator().run() function to run to re-create the indexes. Otherwise we will face an interruption of service with the error:

redis.exceptions.ResponseError: runner-manager:runner_manager.models.runner_group.RunnerGroup:index: no such index

The following actions were taken in the code:

  • Reduce the index interval from one hour to 15 minutes.
  • Add more context to the indexing function, with this information.
  • When failing to contact the redis instance, on the healtcheck, schedule a index run for a more dynamic self-healing approach.

@tcarmet tcarmet requested a review from a team as a code owner June 3, 2024 23:15
@tcarmet tcarmet force-pushed the feature/PTFE-1798-index-error-redis branch from b5fae7d to 766ed68 Compare June 3, 2024 23:16
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.21%. Comparing base (ba90755) to head (c5e8b95).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
- Coverage   86.38%   86.21%   -0.17%     
==========================================
  Files          33       33              
  Lines        1381     1386       +5     
==========================================
+ Hits         1193     1195       +2     
- Misses        188      191       +3     
Flag Coverage Δ
api 63.85% <88.88%> (+0.13%) ⬆️
unit 68.54% <44.44%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcarmet tcarmet merged commit 8f1c99a into main Jun 4, 2024
12 checks passed
@tcarmet tcarmet deleted the feature/PTFE-1798-index-error-redis branch June 4, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants