Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose os and arch param for BaseRunnerGroup #651

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

monabhardwaj
Copy link
Contributor

  • The config params loaded in settings maps to the BaseRunnerGroup .
  • Added os and arch params to the BaseRunnerGroup in order to configure them through the config yaml.
  • This is required for filtering the download_url

- The config params loaded in [settings](https://github.com/monabhardwaj/runner-manager/blob/main/runner_manager/models/settings.py#L33) maps to the [BaseRunnerGroup](https://github.com/monabhardwaj/runner-manager/blob/main/runner_manager/models/runner_group.py#L32) . 
- Added `os` and `arch` params to the BaseRunnerGroup in order to configure them through the config yaml.
- This is required for filtering the [download_url](https://github.com/monabhardwaj/runner-manager/blob/main/runner_manager/models/runner_group.py#L130)
@monabhardwaj monabhardwaj marked this pull request as ready for review July 22, 2024 14:44
@monabhardwaj monabhardwaj requested a review from a team as a code owner July 22, 2024 14:44
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.77%. Comparing base (99a4199) to head (6e6860e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
+ Coverage   86.54%   86.77%   +0.22%     
==========================================
  Files          34       34              
  Lines        1420     1422       +2     
==========================================
+ Hits         1229     1234       +5     
+ Misses        191      188       -3     
Flag Coverage Δ
api 65.18% <100.00%> (+0.04%) ⬆️
unit 67.72% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tcarmet tcarmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @monabhardwaj for your contribution!

LGTM

@tcarmet tcarmet merged commit 137f4a6 into scality:main Jul 22, 2024
9 of 11 checks passed
@monabhardwaj monabhardwaj deleted the expose-required-param branch July 23, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants