Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: allow EC2 instance access to metadata tags #681

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

cej-harris
Copy link
Contributor

At the moment it is not possible to allow EC2 instances to access their metadata tags when they are created. The changes in this PR adds a field within the AWS backend to create EC2 instances, specifying if the InstanceMetadataTags option in InstanceMetadataOptions is disabled (the default) or enabled. This option can be configured with the instance_metadata_tags option in runner-manager.yaml

@cej-harris cej-harris requested a review from a team as a code owner September 23, 2024 13:35
Copy link
Contributor

@tcarmet tcarmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution !

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.74%. Comparing base (e4e66df) to head (edb5285).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
+ Coverage   86.72%   86.74%   +0.01%     
==========================================
  Files          34       34              
  Lines        1431     1433       +2     
==========================================
+ Hits         1241     1243       +2     
  Misses        190      190              
Flag Coverage Δ
api 64.89% <66.66%> (-0.03%) ⬇️
unit 67.48% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcarmet tcarmet merged commit bdf1fcf into scality:main Sep 25, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants