Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3UTILS-149 Prevent deleting versions with pending replication #301

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

nicolas2bert
Copy link
Contributor

@nicolas2bert nicolas2bert commented Oct 18, 2023

Introducing EXCLUDE_REPLICATING_VERSIONS to prevent the deletion of replicating versions.

@bert-e
Copy link
Contributor

bert-e commented Oct 18, 2023

Hello nicolas2bert,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 18, 2023

Incorrect fix version

The Fix Version/s in issue S3UTILS-149 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.14.1

Please check the Fix Version/s of S3UTILS-149, or the target
branch of this pull request.

@nicolas2bert nicolas2bert force-pushed the improvement/S3UTILS-149/skip branch from b3bbccd to 57a73a1 Compare October 19, 2023 07:43
Copy link
Contributor

@benzekrimaha benzekrimaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolas2bert nicolas2bert force-pushed the improvement/S3UTILS-149/skip branch from 57a73a1 to 9b73913 Compare October 26, 2023 08:15
@nicolas2bert
Copy link
Contributor Author

@bert-e approve

@bert-e
Copy link
Contributor

bert-e commented Oct 26, 2023

Incorrect fix version

The Fix Version/s in issue S3UTILS-149 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.14.1

Please check the Fix Version/s of S3UTILS-149, or the target
branch of this pull request.

The following options are set: approve

@nicolas2bert
Copy link
Contributor Author

ping

@bert-e
Copy link
Contributor

bert-e commented Oct 26, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/1.14

The following branches will NOT be impacted:

  • development/1.13
  • development/1.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 26, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.14

The following branches have NOT changed:

  • development/1.13
  • development/1.4

Please check the status of the associated issue S3UTILS-149.

Goodbye nicolas2bert.

@bert-e bert-e merged commit 9b73913 into development/1.14 Oct 26, 2023
12 checks passed
@bert-e bert-e deleted the improvement/S3UTILS-149/skip branch October 26, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants