Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count items crashes if a bucket has a website configuration #322

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Count items crashes if a bucket has a website configuration #322

merged 2 commits into from
Jul 8, 2024

Conversation

williamlardier
Copy link
Contributor

@williamlardier williamlardier commented Jun 26, 2024 •
edited by francoisferrand
Loading

This bug is fixed by nullifying nay website configuration before creating the Arsenal object, as we do not need anything related to websites in count items.

Issue: S3UTILS-168

@bert-e
Copy link
Contributor

bert-e commented Jun 26, 2024

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

francoisferrand
francoisferrand reviewed Jun 26, 2024
View reviewed changes
CountItems/CountWorker.js Outdated
@@ -30,6 +30,11 @@ class CountWorker {
if (!this.client.client) {
return callback(new Error('NotConnected'));
}
// 'fromObj' expects that the website configuration is an instance of
// WebsiteConfiguration As it it not used in CountItems, we nullify it.
Copy link
Contributor

@francoisferrand francoisferrand Jun 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would be not be a WebsiteConfiguration ? There is probably another root cause, would be best to fix it instead of masking it with a band-aid...

Copy link
Contributor Author

@williamlardier williamlardier Jun 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not band-aid: the function we use, fromObj, loads an object and expects the website configuration to be of the right instance, it is not the deSerialize method, where we accept a non-instanciated JSON object. The latter could be used, but we would need to serialize the bucket metadata object. I chose to keep the same function, but adapt the object to pass the class asserts... (less computations)

why would be not be a WebsiteConfiguration ?

Because this object comes from MongoDB, and has no specific class inside, it's just an object with fields.

Copy link
Contributor Author

@williamlardier williamlardier Jun 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will also definitely not update arsenal for the count-items job, that we really need to drop today...

benzekrimaha
benzekrimaha approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@benzekrimaha benzekrimaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scality scality deleted a comment from bert-e Jun 28, 2024
@scality scality deleted a comment from bert-e Jun 28, 2024
@bert-e
Copy link
Contributor

bert-e commented Jun 28, 2024

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@williamlardier
Copy link
Contributor Author

/create_integration_branches

@scality scality deleted a comment from bert-e Jun 28, 2024
@bert-e
Copy link
Contributor

bert-e commented Jun 28, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@williamlardier
Copy link
Contributor Author

/approve

@williamlardier @francoisferrand
S3UTILS-168: remove any website configuration
ce4472c 
The website configuration object, when calling "fromObj" must be
of type WebsiteConfiguration, otherwise, an assert will fail, and
this will cause a crash of count items.
@williamlardier @francoisferrand
S3UTILS-168: bump project to 1.14.12
e96a3d1
@scality scality deleted a comment from williamlardier Jul 8, 2024
@bert-e
Copy link
Contributor

bert-e commented Jul 8, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: approve, create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Jul 8, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.14

  • ✔️ development/1.15

The following branches have NOT changed:

  • development/1.13
  • development/1.4

Please check the status of the associated issue S3UTILS-168.

Goodbye williamlardier.

The following options are set: approve, create_integration_branches

@bert-e bert-e merged commit e96a3d1 into development/1.14 Jul 8, 2024
10 checks passed
@bert-e bert-e deleted the bugfix/S3UTILS-168 branch July 8, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benzekrimaha benzekrimaha benzekrimaha approved these changes

@francoisferrand francoisferrand francoisferrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@williamlardier @bert-e @francoisferrand @benzekrimaha