-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid duplicate countitems metrics #324
Conversation
Metrics from both workers & managers are instantiated in both kind of processes, leading to duplicates when merging (naively) the metrics. Improving merge is not trivial, for now we simply are more careful about instantiating the metrics: `bucketProcessingDuration` and `consolidationDuration` are only instantiated on master process. Since they have labels, `bucketsCount` and `objectsCount` are not affected, so we can keep them as is for now (since they are used directly from S3UtilsMongoClient, and would need a significant refactor to make it work both in prod and tests). Issue: S3UTILS-175
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
Issue: S3UTILS-175
/approve |
Build failedThe build for commit did not succeed in branch w/1.15/bugfix/S3UTILS-175. The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue S3UTILS-175. Goodbye francoisferrand. The following options are set: approve |
Metrics from both workers & managers are instantiated in both kind of
processes, leading to duplicates when merging (naively) the metrics.
Improving merge is not trivial, for now we simply are more careful about
instantiating the metrics:
bucketProcessingDuration
andconsolidationDuration
are only instantiated on master process. Sincethey have labels,
bucketsCount
andobjectsCount
are not affected, sowe can keep them as is for now (since they are used directly from
S3UtilsMongoClient, and would need a significant refactor to make it
work both in prod and tests).
Issue: S3UTILS-175