bump deps

eslint.config.mjs

@@ -0,0 +1,33 @@
+import mocha from "eslint-plugin-mocha";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import js from "@eslint/js";
+import { FlatCompat } from "@eslint/eslintrc";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+    baseDirectory: __dirname,
+    recommendedConfig: js.configs.recommended,
+    allConfig: js.configs.all
+});
+
+export default [...compat.extends("scality"), {
+    plugins: {
+        mocha,
+    },
+
+    languageOptions: {
+        ecmaVersion: 2020,
+        sourceType: "script",
+    },
+
+    rules: {
+        "import/extensions": "off",
+        "lines-around-directive": "off",
+        "no-underscore-dangle": "off",
+        "quote-props": "off",
+        "mocha/no-exclusive-tests": "error",
+        "no-param-reassign": "off",
+    },
+}];

examples/javascript-V4Auth-example.js

@@ -1,5 +1,4 @@
 const http = require('http');
-// eslint-disable-next-line import/no-extraneous-dependencies
 const aws4 = require('aws4');
 
 // Input AWS access key, secret key, and session token.

index.js

@@ -1,5 +1,5 @@
-/* eslint-disable global-require */
-// eslint-disable-line strict
+ 
+ 
 let toExport;
 
 if (process.env.ENABLE_UTAPI_V2) {

lib/Config.js

@@ -1,4 +1,4 @@
-/* eslint-disable no-bitwise */
+ 
 const assert = require('assert');
 const fs = require('fs');
 const path = require('path');

lib/ListMetrics.js

@@ -1,7 +1,5 @@
-/* eslint-disable prefer-spread */
-/* eslint-disable prefer-destructuring */
-/* eslint-disable class-methods-use-this */
-/* eslint-disable no-mixed-operators */
+
+
 const async = require('async');
 const { errors } = require('arsenal');
 const { getMetricFromKey, getKeys, generateStateKey } = require('./schema');
@@ -175,7 +173,7 @@ class ListMetrics {
         const end = range[1] || Date.now();
         const subRangesCount = Math.floor((end - start) / MAX_RANGE_MS) + 1;
         const subRanges = [];
-        // eslint-disable-next-line no-plusplus
+         
         for (let i = 0; i < subRangesCount; i++) {
             if (i + 1 === subRangesCount) {
                 subRanges.push([start, end]);

lib/UtapiClient.js

@@ -1,6 +1,5 @@
-/* eslint-disable prefer-destructuring */
-/* eslint-disable class-methods-use-this */
-/* eslint-disable no-mixed-operators */
+
+
 const assert = require('assert');
 const { doUntil, parallel } = require('async');
 const werelogs = require('werelogs');

lib/UtapiReplay.js

@@ -1,4 +1,4 @@
-/* eslint-disable no-plusplus */
+ 
 const assert = require('assert');
 const async = require('async');
 const { scheduleJob } = require('node-schedule');

lib/backend/Memory.js

@@ -1,4 +1,4 @@
-/* eslint-disable class-methods-use-this */
+ 
 const assert = require('assert');
 const map = require('async/map');
 

lib/server.js

@@ -1,4 +1,4 @@
-/* eslint-disable class-methods-use-this */
+ 
 const http = require('http');
 const https = require('https');
 const url = require('url');
@@ -49,15 +49,15 @@ class UtapiServer {
         if (typeof component === 'string') {
             try {
                 decodeURIComponent(component);
-            } catch (err) {
+            } catch {
                 return true;
             }
         } else {
             return Object.keys(component).find(x => {
                 try {
                     decodeURIComponent(x);
                     decodeURIComponent(component[x]);
-                } catch (err) {
+                } catch {
                     return true;
                 }
                 return false;

libV2/cache/backend/memory.js

@@ -20,12 +20,12 @@ class MemoryCache {
         this._expirations = {};
     }
 
-    // eslint-disable-next-line class-methods-use-this
+     
     async connect() {
         return true;
     }
 
-    // eslint-disable-next-line class-methods-use-this
+     
     async disconnect() {
         Object.values(this._expirations).forEach(clearTimeout);
         return true;

libV2/client/index.js

@@ -1,14 +1,12 @@
 const { callbackify } = require('util');
 const { Transform } = require('stream');
-const uuid = require('uuid');
+const { v4: uuid } = require('uuid');
 const needle = require('needle');
 
 // These modules are added via the `level-mem` package rather than individually
-/* eslint-disable import/no-extraneous-dependencies */
 const levelup = require('levelup');
 const memdown = require('memdown');
 const encode = require('encoding-down');
-/* eslint-enable import/no-extraneous-dependencies */
 
 const { UtapiMetric } = require('../models');
 const {
@@ -257,7 +255,7 @@ class UtapiClient {
 
         // Assign a uuid if one isn't passed
         if (!metric.uuid) {
-            metric.uuid = uuid.v4();
+            metric.uuid = uuid();
         }
 
         // Assign a timestamp if one isn't passed

libV2/config/index.js

@@ -137,10 +137,9 @@ class Config {
             new Set([
                 ...Object.keys(parent),
                 ...Object.keys(child)],
-            // eslint-disable-next-line function-paren-newline
+             
             ))
             .reduce((ret, key) => {
-                // eslint-disable-next-line no-param-reassign
                 ret[key] = this._recursiveUpdate(parent[key], child[key]);
                 return ret;
             }, {});

libV2/errors/index.js

@@ -1,4 +1,3 @@
-/* eslint-disable no-param-reassign */
 const utapiErrors = require('./errors.json');
 
 class UtapiError extends Error {

libV2/metadata/index.js

@@ -1,4 +1,4 @@
-/* eslint-disable no-restricted-syntax */
+ 
 const arsenal = require('arsenal');
 const async = require('async');
 const metadata = require('./client');
@@ -45,7 +45,7 @@ function _listObject(bucket, prefix, hydrateFunc) {
                 let res;
 
                 try {
-                    // eslint-disable-next-line no-await-in-loop
+                     
                     res = await async.retryable(ebConfig, _listingWrapper)(bucket, { ...listingParams, gt });
                 } catch (error) {
                     moduleLogger.error('Error during listing', { error });

libV2/models/Base.js

@@ -53,14 +53,14 @@ function buildModel(name, schema) {
     Object.keys(schema).forEach(key =>
         Object.defineProperty(Model.prototype, key, {
             // `function` is used rather than `=>` to work around context problem with `this`
-            /* eslint-disable func-names, object-shorthand */
+            /* eslint-disable object-shorthand */
             get: function () {
                 return this._get(key);
             },
             set: function (value) {
                 this._set(key, value);
             },
-            /* eslint-enable func-names, object-shorthand */
+            /* eslint-enable object-shorthand */
         }));
     return Model;
 }

libV2/process.js

@@ -33,13 +33,13 @@ class Process extends EventEmitter {
         await this._join();
     }
 
-    /* eslint-disable class-methods-use-this,no-empty-function */
+     
     async _setup() {}
 
     async _start() {}
 
     async _join() {}
-    /* eslint-enable class-methods-use-this,no-empty-function */
+     
 }
 
 module.exports = Process;

libV2/server/API/internal/healthcheck.js

@@ -1,5 +1,4 @@
 async function healthcheck(ctx) {
-    // eslint-disable-next-line no-param-reassign
     ctx.results.statusCode = 200;
 }
 

libV2/server/API/internal/prometheusMetrics.js

@@ -6,7 +6,7 @@ collectDefaultMetrics({
 });
 
 async function prometheusMetrics(ctx) {
-    // eslint-disable-next-line no-param-reassign
+     
     ctx.results.statusCode = 200;
     ctx.results.body = await register.metrics();
 }

libV2/server/API/metrics/ingestMetric.js

@@ -12,15 +12,15 @@ async function ingestMetric(ctx, params) {
             timestamp: convertTimestamp(m.timestamp),
             operationId: ingestionOpTranslationMap[m.operationId] || m.operationId,
         }));
-    } catch (error) {
+    } catch {
         throw errors.InvalidRequest;
     }
     try {
         await Promise.all(metrics.map(m => cacheClient.pushMetric(m)));
-    } catch (error) {
+    } catch {
         throw errors.ServiceUnavailable;
     }
-    // eslint-disable-next-line no-param-reassign
+     
     ctx.results.statusCode = 200;
 }
 

libV2/server/controller.js

@@ -1,4 +1,3 @@
-/* eslint-disable no-param-reassign */
 const { apiOperations, apiOperationMiddleware } = require('./spec');
 const { middleware: utapiMiddleware } = require('./middleware');
 const RequestContext = require('../models/RequestContext');
@@ -23,7 +22,6 @@ class APIController {
 
     static _safeRequire(path) {
         try {
-            // eslint-disable-next-line import/no-dynamic-require, global-require
             return require(path);
         } catch (error) {
             if (error.code !== 'MODULE_NOT_FOUND') {

libV2/server/middleware.js

@@ -39,7 +39,6 @@ async function initializeOasTools(spec, app) {
 }
 
 function loggerMiddleware(req, res, next) {
-    // eslint-disable-next-line no-param-reassign
     req.logger = buildRequestLogger(req);
     req.logger.info('Received request');
     return next();
@@ -83,11 +82,11 @@ function errorMiddleware(err, req, res, next) {
     // failed request validation by oas-tools
     if (err.failedValidation) {
         // You can't actually use destructing here
-        /* eslint-disable prefer-destructuring */
+         
         statusCode = errors.InvalidRequest.code;
         code = errors.InvalidRequest.message;
         message = errors.InvalidRequest.description;
-        /* eslint-enable prefer-destructuring */
+         
     }
 
     if (!err.utapiError && !config.development) {
@@ -103,7 +102,7 @@ function errorMiddleware(err, req, res, next) {
     responseLoggerMiddleware(req, res, () => httpMetricsMiddleware(req, res));
 }
 
-// eslint-disable-next-line no-unused-vars
+ 
 async function authV4Middleware(request, response, params) {
     const authHeader = request.headers.authorization;
     if (!authHeader || !authHeader.startsWith('AWS4-')) {

libV2/server/spec.js

@@ -26,7 +26,7 @@ function _getApiOperationIds(routes) {
                         .with({ method: '_getApiOperationIds' })
                         .trace('Registering handler', { tag, operationId: optId });
                     if (optIds[tag] === undefined) {
-                        // eslint-disable-next-line no-param-reassign
+                         
                         optIds[tag] = new Set([optId]);
                     } else {
                         optIds[tag].add(optId);

libV2/tasks/BaseTask.js

@@ -92,7 +92,7 @@ class BaseTask extends Process {
         };
     }
 
-    // eslint-disable-next-line class-methods-use-this
+     
     _registerMetricHandlers() {
         return {};
     }
@@ -175,7 +175,7 @@ class BaseTask extends Process {
         }
     }
 
-    // eslint-disable-next-line class-methods-use-this
+     
     async _execute(timestamp) {
         logger.info(`Default Task ${timestamp}`);
     }

libV2/tasks/CreateCheckpoint.js

@@ -21,7 +21,7 @@ class CreateCheckpoint extends BaseTask {
         this._defaultLag = checkpointLagSecs;
     }
 
-    // eslint-disable-next-line class-methods-use-this
+     
     _registerMetricHandlers() {
         const created = new promClient.Counter({
             name: 's3_utapi_create_checkpoint_created_total',

libV2/tasks/CreateSnapshot.js

@@ -21,7 +21,7 @@ class CreateSnapshot extends BaseTask {
         this._defaultLag = snapshotLagSecs;
     }
 
-    // eslint-disable-next-line class-methods-use-this
+     
     _registerMetricHandlers() {
         const created = new promClient.Counter({
             name: 's3_utapi_create_snapshot_created_total',

libV2/tasks/DiskUsage.js

@@ -49,7 +49,7 @@ class MonitorDiskUsage extends BaseTask {
             );
     }
 
-    // eslint-disable-next-line class-methods-use-this
+     
     _registerMetricHandlers() {
         const isLocked = new promClient.Gauge({
             name: 's3_utapi_monitor_disk_usage_is_locked',
@@ -143,7 +143,7 @@ class MonitorDiskUsage extends BaseTask {
         return this._program.lock !== undefined;
     }
 
-    // eslint-disable-next-line class-methods-use-this
+     
     async _getUsage(path) {
         moduleLogger.debug(`calculating disk usage for ${path}`);
         if (!fs.existsSync(path)) {

libV2/tasks/IngestShard.js

@@ -29,7 +29,7 @@ class IngestShardTask extends BaseTask {
         this._stripEventUUID = options.stripEventUUID !== undefined ? options.stripEventUUID : true;
     }
 
-    // eslint-disable-next-line class-methods-use-this
+     
     _registerMetricHandlers() {
         const ingestedTotal = new promClient.Counter({
             name: 's3_utapi_ingest_shard_task_ingest_total',
@@ -151,7 +151,7 @@ class IngestShardTask extends BaseTask {
 
                         let ingestedIntoNodeId;
                         const status = await this.withWarp10(async warp10 => {
-                            // eslint-disable-next-line prefer-destructuring
+                             
                             ingestedIntoNodeId = warp10.nodeId;
                             return warp10.ingest(
                                 {