fix types

scality · Nov 4, 2024 · 44bccd7 · 44bccd7
1 parent 5eb81f4
commit 44bccd7
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 5 deletions.
diff --git a/src/react/databrowser/objects/MetadataSearch.tsx b/src/react/databrowser/objects/MetadataSearch.tsx
@@ -156,7 +156,6 @@ const MetadataSearch = ({ isMetadataType, errorZenkoMsg }: Props) => {
             right: '10px',
             cursor: 'pointer',
           }}
-          //@ts-expect-error Need to improve typing on core-ui for including the event
           onClick={reset}
         />
       </SearchMetadataInputAndIcon>

diff --git a/src/react/next-architecture/ui/AuthProvider.tsx b/src/react/next-architecture/ui/AuthProvider.tsx
@@ -19,7 +19,10 @@ export function useInstanceId() {
 
   const instanceIds = user?.userData?.original?.profile?.instanceIds;
 
-  if (!instanceIds || instanceIds.length === 0) {
+  if (
+    !instanceIds ||
+    (Array.isArray(instanceIds) && instanceIds.length === 0)
+  ) {
     return '';
   }
 

diff --git a/src/react/next-architecture/ui/XCoreLibraryProvider.tsx b/src/react/next-architecture/ui/XCoreLibraryProvider.tsx
@@ -29,7 +29,7 @@ const InternalXcoreLibraryProvider = ({
 }: {
   moduleExports: Record<string, never>;
   children: React.ReactNode;
-}): React.ReactNode => {
+}) => {
   //@ts-expect-error fix this when you are working on it
   xcoreLibraryGlobal.hooks = moduleExports['./xcoreLibrary'];
   return <>{children}</>;

diff --git a/src/react/ui-elements/EditableKeyValue.tsx b/src/react/ui-elements/EditableKeyValue.tsx
@@ -159,7 +159,6 @@ export const AddButton = ({
           overlay: 'Add',
           placement: 'top',
         }}
-        //@ts-expect-error fix this when you are working on it
         icon={<Icon name="Add-plus" style={iconStyle} />}
       />
     </>
@@ -200,7 +199,6 @@ export const SubButton = ({
         overlay: 'Remove',
         placement: 'top',
       }}
-      //@ts-expect-error fix this when you are working on it
       icon={<Icon name="Remove-minus" style={iconStyle} />}
     />
   );

diff --git a/src/react/utils/testUtil.tsx b/src/react/utils/testUtil.tsx
@@ -114,6 +114,7 @@ export const defaultUserData = {
   groups: ['user', 'PlatformAdmin'],
   original: {
     id_token: 'idtoken',
+    session_state: null,
     access_token: 'token',
     token_type: 'bearer',
     scope: 'openid profile email',