ARTESCA-11299: Add test to prevent the edition of Artesca default loc…

…ation
scality · Jul 2, 2024 · 9d10696 · 9d10696
1 parent 77dd4d4
commit 9d10696
Show file tree

Hide file tree

Showing 5 changed files with 115 additions and 19 deletions.
diff --git a/src/js/mock/managementClientMSWHandlers.ts b/src/js/mock/managementClientMSWHandlers.ts
@@ -144,17 +144,22 @@ export const LOCATIONS = {
     name: 'ring-nick',
     objectId: '99a06f79-c62c-11ec-b993-7e8a0ab79998',
   },
-  'us-east-1': {
-    isBuiltin: true,
-    locationType: 'location-file-v1',
-    name: 'us-east-1',
-    objectId: '95dbedf5-9888-11ec-8565-1ac2af7d1e53',
-  },
   [azureblobstorage]: {
     locationType: 'location-azure-v1',
     name: azureblobstorage,
     details: {},
   },
+  'us-east-1': {
+    details: {
+      bootstrapList: [
+        'artesca-storage-service-hdservice-proxy.xcore.svc:18888',
+      ],
+      repoId: null,
+    },
+    locationType: 'location-scality-hdclient-v2',
+    name: 'us-east-1',
+    objectId: '22f31240-4bd3-11ee-98b3-1e5b6f897bc7',
+  },
 };
 
 export const ENDPOINTS = [

diff --git a/src/react/locations/LocationsList.tsx b/src/react/locations/LocationsList.tsx
@@ -178,6 +178,7 @@ const ActionButtons = ({
             variant="danger"
             onClick={() => setShowModal(true)}
             type="button"
+            aria-label="Delete Location"
             tooltip={{
               overlay: <TooltipOverlay />,
               overlayStyle: { textAlign: 'left' },
@@ -220,7 +221,6 @@ export function LocationsList() {
   const loadingBuckets = useSelector(
     (state: AppState) => state.networkActivity.counter > 0,
   );
-
   const SEARCH_QUERY_PARAM = 'search';
   const columns = useMemo(() => {
     const dataUsedColumn = getDataUsedColumn(

diff --git a/src/react/locations/__tests__/LocationEditor.test.tsx b/src/react/locations/__tests__/LocationEditor.test.tsx
@@ -49,13 +49,11 @@ describe('LocationEditor', () => {
     );
     await selectClick(selector);
     await userEvent.keyboard('{arrowup}');
-
     expect(
       container.querySelector('.sc-select__option--is-focused')?.textContent,
-    ).toBe('Storage Service for ARTESCA');
+    ).toBe('Scality ARTESCA S3');
 
     [
-      'Scality ARTESCA S3',
       'Scality RING with S3 Connector',
       'Amazon S3',
       'Google Cloud Storage',

diff --git a/src/react/locations/__tests__/LocationList.test.tsx b/src/react/locations/__tests__/LocationList.test.tsx
@@ -0,0 +1,93 @@
+import {
+  screen,
+  waitFor,
+  waitForElementToBeRemoved,
+  within,
+} from '@testing-library/react';
+import { setupServer } from 'msw/node';
+import { rest } from 'msw';
+import {
+  ACCOUNT_ID,
+  getConfigOverlay,
+  getStorageConsumptionMetricsHandlers,
+} from '../../../js/mock/managementClientMSWHandlers';
+import {
+  TEST_API_BASE_URL,
+  mockOffsetSize,
+  renderWithRouterMatch,
+  zenkoUITestConfig,
+} from '../../utils/testUtil';
+import { INSTANCE_ID } from '../../actions/__tests__/utils/testUtil';
+import { LocationsList } from '../LocationsList';
+import { debug } from 'jest-preview';
+
+const server = setupServer(
+  getConfigOverlay(TEST_API_BASE_URL, INSTANCE_ID),
+  ...getStorageConsumptionMetricsHandlers(
+    zenkoUITestConfig.managementEndpoint,
+    INSTANCE_ID,
+  ),
+  rest.get(
+    `${TEST_API_BASE_URL}/api/v1/instance/${INSTANCE_ID}/status`,
+    (req, res, ctx) => res(ctx.json({})),
+  ),
+  rest.post(`${TEST_API_BASE_URL}/`, (req, res, ctx) => {
+    //@ts-ignore
+    const params = new URLSearchParams(req.body);
+    if (params.get('Action') === 'GetRolesForWebIdentity') {
+      const TEST_ACCOUNT = 'Test Account';
+      const TEST_ACCOUNT_CREATION_DATE = '2022-03-18T12:51:44Z';
+      return res(
+        ctx.json({
+          IsTruncated: false,
+          Accounts: [
+            {
+              Name: TEST_ACCOUNT,
+              CreationDate: TEST_ACCOUNT_CREATION_DATE,
+              Roles: [
+                {
+                  Name: 'storage-manager-role',
+                  Arn: `arn:aws:iam::${ACCOUNT_ID}:role/scality-internal/storage-manager-role`,
+                },
+              ],
+            },
+          ],
+        }),
+      );
+    }
+  }),
+);
+
+describe('LocationList', () => {
+  beforeAll(() => {
+    jest.setTimeout(20_000);
+    mockOffsetSize(500, 100);
+    server.listen({ onUnhandledRequest: 'error' });
+  });
+  afterEach(() => {
+    server.resetHandlers();
+  });
+  afterAll(() => {
+    server.close();
+  });
+  it('should disable the delete button for default location', async () => {
+    //S
+    renderWithRouterMatch(<LocationsList />);
+    //E
+    await waitForElementToBeRemoved(() => [
+      ...screen.queryAllByText(/Loading/i),
+    ]);
+    const hdLocationRow = screen.getByRole('row', {
+      name: /us-east-1 Storage Service for ARTESCA/i,
+    });
+    //V
+    await waitFor(() => {
+      expect(
+        within(hdLocationRow).getByRole('button', {
+          name: /Edit Location/i,
+        }),
+      ).toBeDisabled();
+    });
+    debug();
+  });
+});
diff --git a/src/react/workflow/__tests__/TransitionForm.test.tsx b/src/react/workflow/__tests__/TransitionForm.test.tsx
@@ -200,15 +200,15 @@ describe('TransitionForm', () => {
     await waitFor(() =>
       screen.getByRole('option', {
         name: new RegExp(
-          `${notVersionedBucket} \\(us-east-1 / Local Filesystem \\)`,
+          `${notVersionedBucket} \\(us-east-1 / Storage Service \\)`,
           'i',
         ),
       }),
     );
     await userEvent.click(
       screen.getByRole('option', {
         name: new RegExp(
-          `${notVersionedBucket} \\(us-east-1 / Local Filesystem \\)`,
+          `${notVersionedBucket} \\(us-east-1 / Storage Service \\)`,
           'i',
         ),
       }),
@@ -233,15 +233,15 @@ describe('TransitionForm', () => {
     await waitFor(() =>
       screen.getByRole('option', {
         name: new RegExp(
-          `${versionedBucket} \\(us-east-1 / Local Filesystem \\)`,
+          `${versionedBucket} \\(us-east-1 / Storage Service \\)`,
           'i',
         ),
       }),
     );
     await userEvent.click(
       screen.getByRole('option', {
         name: new RegExp(
-          `${versionedBucket} \\(us-east-1 / Local Filesystem \\)`,
+          `${versionedBucket} \\(us-east-1 / Storage Service \\)`,
           'i',
         ),
       }),
@@ -336,15 +336,15 @@ describe('TransitionForm', () => {
     await waitFor(() =>
       screen.getByRole('option', {
         name: new RegExp(
-          `${notVersionedBucket} \\(us-east-1 / Local Filesystem \\)`,
+          `${notVersionedBucket} \\(us-east-1 / Storage Service \\)`,
           'i',
         ),
       }),
     );
     await userEvent.click(
       screen.getByRole('option', {
         name: new RegExp(
-          `${notVersionedBucket} \\(us-east-1 / Local Filesystem \\)`,
+          `${notVersionedBucket} \\(us-east-1 / Storage Service \\)`,
           'i',
         ),
       }),
@@ -384,15 +384,15 @@ describe('TransitionForm', () => {
     await waitFor(() =>
       screen.getByRole('option', {
         name: new RegExp(
-          `${notVersionedBucket} \\(us-east-1 / Local Filesystem \\)`,
+          `${notVersionedBucket} \\(us-east-1 / Storage Service \\)`,
           'i',
         ),
       }),
     );
     await userEvent.click(
       screen.getByRole('option', {
         name: new RegExp(
-          `${notVersionedBucket} \\(us-east-1 / Local Filesystem \\)`,
+          `${notVersionedBucket} \\(us-east-1 / Storage Service \\)`,
           'i',
         ),
       }),
@@ -435,7 +435,7 @@ describe('TransitionForm', () => {
     userEvent.click(
       screen.getByRole('option', {
         name: new RegExp(
-          `${versionedBucket} \\(us-east-1 / Local Filesystem \\)`,
+          `${versionedBucket} \\(us-east-1 / Storage Service \\)`,
           'i',
         ),
       }),