-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the page fully reload upon token renewal and assume role after account creation #644
Fix the page fully reload upon token renewal and assume role after account creation #644
Conversation
Hello chengyanjin,My role is to assist you with the merge of this Status report is not available. |
Codecov Report
@@ Coverage Diff @@
## development/1.6 #644 +/- ##
===================================================
+ Coverage 55.45% 55.63% +0.18%
===================================================
Files 218 218
Lines 10454 10457 +3
Branches 2942 2939 -3
===================================================
+ Hits 5797 5818 +21
+ Misses 4636 4618 -18
Partials 21 21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/2.0/bugfix/ZKUI-378-fix-the-bug-of-post-account-create origin/development/2.0
$ git merge origin/bugfix/ZKUI-378-fix-the-bug-of-post-account-create
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/2.0/bugfix/ZKUI-378-fix-the-bug-of-post-account-create |
/approve |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/2.1/bugfix/ZKUI-378-fix-the-bug-of-post-account-create origin/development/2.1
$ git merge origin/w/2.0/bugfix/ZKUI-378-fix-the-bug-of-post-account-create
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/2.1/bugfix/ZKUI-378-fix-the-bug-of-post-account-create The following options are set: approve |
/status |
StatusStatus report is not available. The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ZKUI-378. Goodbye chengyanjin. |
This PR fixed two issues explained below:
Zenko UI gets fully reload upon token renewal is caused by the wrongly added
token
within queryKey when fetchingWebIdentityRoles
. However it is totally unnecessary.After account creation, we switch to the new account so we should assume role again which is missing before, cause the issue that we still load the IAM User/ policy of previous account.