Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZKUI-387: No basepath for development when initing s3 and iam client #664

Merged

Conversation

ChengYanJin
Copy link
Contributor

In order to run all the UIs in local development

@bert-e
Copy link
Contributor

bert-e commented Oct 26, 2023

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 26, 2023

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@codecov-commenter
Copy link

Codecov Report

Merging #664 (38effb5) into development/2.1 (61c5b98) will decrease coverage by 0.07%.
The diff coverage is 50.00%.

@@                 Coverage Diff                 @@
##           development/2.1     #664      +/-   ##
===================================================
- Coverage            58.28%   58.22%   -0.07%     
===================================================
  Files                  208      208              
  Lines                10166    10168       +2     
  Branches              2946     2948       +2     
===================================================
- Hits                  5925     5920       -5     
- Misses                4225     4232       +7     
  Partials                16       16              
Files Coverage Δ
...rc/react/next-architecture/ui/S3ClientProvider.tsx 53.57% <100.00%> (+0.84%) ⬆️
src/react/actions/auth.ts 44.44% <0.00%> (-1.02%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Contributor

@JBWatenbergScality JBWatenbergScality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!!

@ChengYanJin
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Oct 26, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 26, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.1

  • ✔️ development/2.2

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 26, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.1

  • ✔️ development/2.2

The following branches have NOT changed:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0

Please check the status of the associated issue ZKUI-387.

Goodbye chengyanjin.

@bert-e bert-e merged commit 38effb5 into development/2.1 Oct 26, 2023
@bert-e bert-e deleted the feature/ZKUI-387-run-zenko-ui-with-other-UIs-locally branch October 26, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants