Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZKUI-397: refactor bucket overview for Veeam use case #667

Merged
merged 3 commits into from
Nov 14, 2023
Merged

ZKUI-397: refactor bucket overview for Veeam use case #667

merged 3 commits into from
Nov 14, 2023

Conversation

ChengYanJin
Copy link
Contributor

@ChengYanJin ChengYanJin commented Nov 6, 2023 •
edited
Loading

Veeam Bucket:
image

Not Veeam Bucket:
image

Error when loading bucket tagging failed
image

@bert-e
Copy link
Contributor

bert-e commented Nov 6, 2023

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 6, 2023

Incorrect fix version

The Fix Version/s in issue ZKUI-397 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.2.0

Please check the Fix Version/s of ZKUI-397, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Nov 6, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@ChengYanJin ChengYanJin force-pushed the feature/ZKUI-397-refactor-bucket-overview-with-data-protection branch from a8e2166 to d700eab Compare November 7, 2023 15:31
@bert-e
Copy link
Contributor

bert-e commented Nov 7, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@ChengYanJin ChengYanJin force-pushed the feature/ZKUI-397-refactor-bucket-overview-with-data-protection branch from d700eab to ac73c46 Compare November 9, 2023 09:27
@bert-e
Copy link
Contributor

bert-e commented Nov 10, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Nov 13, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@ChengYanJin ChengYanJin force-pushed the feature/ZKUI-397-refactor-bucket-overview-with-data-protection branch from ac73c46 to 3194781 Compare November 13, 2023 13:06
@ChengYanJin ChengYanJin changed the base branch from development/2.2 to feature/ZKUI-396-implement-veeam-summary-page November 13, 2023 13:08
@ChengYanJin ChengYanJin force-pushed the feature/ZKUI-397-refactor-bucket-overview-with-data-protection branch 7 times, most recently from e395b33 to d9ef79b Compare November 13, 2023 17:10
@ChengYanJin ChengYanJin force-pushed the feature/ZKUI-397-refactor-bucket-overview-with-data-protection branch from d9ef79b to 8cd5ddb Compare November 13, 2023 17:16
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (664a0d0) 58.23% compared to head (27f01c8) 58.66%.

Files Patch % Lines
src/react/databrowser/buckets/details/Overview.tsx 86.36% 3 Missing ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##           development/2.2     #667      +/-   ##
===================================================
+ Coverage            58.23%   58.66%   +0.43%     
===================================================
  Files                  214      214              
  Lines                10267    10321      +54     
  Branches              2965     2984      +19     
===================================================
+ Hits                  5979     6055      +76     
+ Misses                4271     4249      -22     
  Partials                17       17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from feature/ZKUI-396-implement-veeam-summary-page to development/2.2 November 14, 2023 08:57
@ChengYanJin ChengYanJin force-pushed the feature/ZKUI-397-refactor-bucket-overview-with-data-protection branch from bc28685 to e88ec5e Compare November 14, 2023 10:24
@ChengYanJin
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Nov 14, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

JBWatenbergScality
JBWatenbergScality approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@JBWatenbergScality JBWatenbergScality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@bert-e
Copy link
Contributor

bert-e commented Nov 14, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.2

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Nov 14, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.2

The following branches have NOT changed:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1

Please check the status of the associated issue ZKUI-397.

Goodbye chengyanjin.

@bert-e bert-e merged commit 27f01c8 into development/2.2 Nov 14, 2023
15 checks passed
@bert-e bert-e deleted the feature/ZKUI-397-refactor-bucket-overview-with-data-protection branch November 14, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBWatenbergScality JBWatenbergScality JBWatenbergScality approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChengYanJin @bert-e @codecov-commenter @JBWatenbergScality