Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZKUI-403 // Federetate Certificate Button #681

Conversation

hervedombya
Copy link
Contributor

No description provided.

Fix import and use of isPlatformAdmin function
@hervedombya hervedombya force-pushed the fixture/ZKUI-403-federate-component-from-artesca-ui branch from 430a75e to a6b047c Compare November 20, 2023 15:02
@codecov-commenter
Copy link

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (664a0d0) 58.23% compared to head (a6b047c) 58.17%.
Report is 5 commits behind head on development/2.2.

Files Patch % Lines
...next-architecture/ui/CertificateDownloadButton.tsx 11.11% 8 Missing ⚠️
src/react/ui-elements/Veeam/VeeamSummary.tsx 45.45% 6 Missing ⚠️
src/react/next-architecture/ui/ConfigProvider.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           development/2.2     #681      +/-   ##
===================================================
- Coverage            58.23%   58.17%   -0.06%     
===================================================
  Files                  214      215       +1     
  Lines                10267    10289      +22     
  Branches              2965     2969       +4     
===================================================
+ Hits                  5979     5986       +7     
- Misses                4271     4286      +15     
  Partials                17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JBWatenbergScality JBWatenbergScality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@hervedombya
Copy link
Contributor Author

/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants