Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/artesca 10858 empty state #735

Merged
merged 27 commits into from
Jun 7, 2024

Conversation

JeanMarcMilletScality
Copy link
Contributor

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Mar 8, 2024

Hello jeanmarcmilletscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Mar 8, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Mar 18, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Mar 20, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 55.76923% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 59.31%. Comparing base (958f489) to head (a541acc).
Report is 8 commits behind head on development/2.2.

Files Patch % Lines
src/react/databrowser/buckets/BucketList.tsx 0.00% 8 Missing ⚠️
src/react/account/AccountUserAccessKeys.tsx 0.00% 3 Missing ⚠️
src/react/account/Accounts.tsx 57.14% 3 Missing ⚠️
src/react/locations/LocationsList.tsx 0.00% 2 Missing ⚠️
src/react/Routes.tsx 0.00% 1 Missing ⚠️
src/react/account/AccountList.tsx 66.66% 1 Missing ⚠️
src/react/account/AccountLocations.tsx 0.00% 1 Missing ⚠️
src/react/databrowser/DataBrowser.tsx 0.00% 1 Missing ⚠️
src/react/databrowser/buckets/details/Workflow.tsx 0.00% 1 Missing ⚠️
src/react/databrowser/objects/ObjectDelete.tsx 50.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##           development/2.2     #735      +/-   ##
===================================================
+ Coverage            59.20%   59.31%   +0.10%     
===================================================
  Files                  239      239              
  Lines                11309    11256      -53     
  Branches              3260     3223      -37     
===================================================
- Hits                  6696     6677      -19     
+ Misses                4592     4559      -33     
+ Partials                21       20       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeanMarcMilletScality JeanMarcMilletScality force-pushed the improvement/ARTESCA-10858-empty-state branch from a541acc to 4bfd4c8 Compare March 25, 2024 10:47
@bert-e
Copy link
Contributor

bert-e commented Mar 25, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JeanMarcMilletScality JeanMarcMilletScality force-pushed the improvement/ARTESCA-10858-empty-state branch from 4bfd4c8 to 58095cc Compare June 4, 2024 15:20
@bert-e
Copy link
Contributor

bert-e commented Jun 4, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Jun 4, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Jun 6, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JeanMarcMilletScality JeanMarcMilletScality marked this pull request as ready for review June 6, 2024 09:24
</EmptyStateContainer>
<EmptyState
icon="Bucket"
link="create-account"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe missing the leading "/"

</EmptyStateContainer>
<EmptyState
icon="Bucket"
link={`accounts/${accountName}/create-bucket`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a leading slash

@bert-e
Copy link
Contributor

bert-e commented Jun 6, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Jun 6, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

Copy link
Contributor

@JBWatenbergScality JBWatenbergScality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@JeanMarcMilletScality
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jun 7, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.2

The following branches have NOT changed:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1

Please check the status of the associated issue ARTESCA-10858.

Goodbye jeanmarcmilletscality.

The following options are set: approve

@bert-e bert-e merged commit 501942e into development/2.2 Jun 7, 2024
9 checks passed
@bert-e bert-e deleted the improvement/ARTESCA-10858-empty-state branch June 7, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants