New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/artesca 13131 enable typescript checking #789

Merged

bert-e merged 13 commits into development/3.0 from improvement/ARTESCA-13131-enable-typescript-checking

Nov 21, 2024

Contributor

MonPote commented Nov 4, 2024

No description provided.

MonPote added 4 commits

November 4, 2024 18:26


          update mf-types

055c7d0


          update module-federation and fixed @types/react

5eb81f4


          fix types

44bccd7


          enable type checking on build

511d758

Contributor

bert-e commented Nov 4, 2024

Hello monpote,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

Contributor

bert-e commented Nov 4, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

Contributor

bert-e commented Nov 4, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

MonPote added 3 commits

November 5, 2024 16:38


          fix types

630ddab


          try to fix ci

478ebb9


          Fix text encoder is not defined

9db76cb

Contributor

bert-e commented Nov 7, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

MonPote added 2 commits

November 8, 2024 14:29


          fix CreateWorkflow.test.tsx

37092a8


          fix ExpirationForm.test.tsx, ReplicationForm.test.tsx and TransitionF…

9f56fb1

…orm.test.tsx tests

MonPote force-pushed the improvement/ARTESCA-13131-enable-typescript-checking branch from 447a906 to 9f56fb1 Compare

November 8, 2024 13:30

MonPote added 2 commits

November 19, 2024 17:08


          update @mf-types

4e14b73


          fix types

f18619f

Contributor

bert-e commented Nov 19, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

Contributor

bert-e commented Nov 19, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

MonPote force-pushed the improvement/ARTESCA-13131-enable-typescript-checking branch from 2aba95b to f18619f Compare

November 20, 2024 14:03


          fix react table custom type not detected

f86cd7a

JBWatenbergScality approved these changes

View reviewed changes

src/react/workflow/__tests__/TransitionForm.test.tsx Outdated Show resolved Hide resolved

Contributor

bert-e commented Nov 21, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:


          small fixes

cd6ad85

Contributor Author

MonPote commented Nov 21, 2024

/approve

Contributor

bert-e commented Nov 21, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/3.0

The following branches have NOT changed:

development/1.4
development/1.5
development/1.6
development/2.0
development/2.1
development/2.2

Please check the status of the associated issue ARTESCA-13131.

Goodbye monpote.

The following options are set: approve

bert-e merged commit cd6ad85 into development/3.0

9 checks passed

bert-e deleted the improvement/ARTESCA-13131-enable-typescript-checking branch

November 21, 2024 15:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet