Merge pull request scandipwa#4939 from lucas-langa/product-gallery

fix yt videos with hyphens, set base image position to a valid one
scandipwa · Jun 23, 2022 · 110996e · 110996e
2 parents 2e51123 + 2ac6ce0
commit 110996e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/scandipwa/src/component/ProductGallery/ProductGallery.container.js b/packages/scandipwa/src/component/ProductGallery/ProductGallery.container.js
@@ -175,7 +175,13 @@ export class ProductGalleryContainer extends PureComponent {
             return acc;
         }, []).sort((a, b) => a - b);
 
-        return positionsArray.findIndex((value) => value === position);
+        const returnValue = positionsArray.findIndex((value) => value === position);
+
+        if (returnValue === -1) {
+            return 0;
+        }
+
+        return returnValue;
     }
 
     getGalleryPictures() {

diff --git a/packages/scandipwa/src/component/VideoPopup/VideoPopup.config.js b/packages/scandipwa/src/component/VideoPopup/VideoPopup.config.js
@@ -18,4 +18,4 @@ export const VIDEO_POPUP_ID = 'VIDEO_POPUP_ID';
  * @type {RegExp}
  */
 export const VIMEO_FORMAT = new RegExp('(?:https?//)?vimeo.com[\\w/]*/(\\d+)$');
-export const YOUTUBE_FORMAT = new RegExp('(?:https?//)?www.youtube.com/watch\\?v=(\\w+)');
+export const YOUTUBE_FORMAT = new RegExp('(?:https?//)?www.youtube.com/watch\\?v=([\\w\\-]+)');