-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated resolver after slider module update #3
base: master
Are you sure you want to change the base?
Updated resolver after slider module update #3
Conversation
if ($slide->getFirstMobileImageLocation()) { | ||
$slideData[$slide::FIRST_MOBILE_IMAGE] = $slide->getFirstMobileImageUrl(); | ||
} | ||
|
||
if ($slide->getFirstDesktopImageLocation()) { | ||
$slideData[$slide::FIRST_DESKTOP_IMAGE] = $slide->getFirstDesktopImageUrl(); | ||
} | ||
|
||
if ($slide->getSecondMobileImageLocation()) { | ||
$slideData[$slide::SECOND_MOBILE_IMAGE] = $slide->getSecondMobileImageUrl(); | ||
} | ||
|
||
if ($slide->getSecondDesktopImageLocation()) { | ||
$slideData[$slide::SECOND_DESKTOP_IMAGE] = $slide->getSecondDesktopImageUrl(); | ||
} | ||
|
||
if ($slide->getThirdMobileImageLocation()) { | ||
$slideData[$slide::THIRD_MOBILE_IMAGE] = $slide->getThirdMobileImageUrl(); | ||
} | ||
unset ($slide); | ||
|
||
if ($sliderData) { | ||
$result = function () use ($sliderData) { | ||
return $sliderData; | ||
}; | ||
if ($slide->getThirdDesktopImageLocation()) { | ||
$slideData[$slide::THIRD_DESKTOP_IMAGE] = $slide->getThirdDesktopImageUrl(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
I guess if there is no image we should get null in response and can handle that on FE.
Isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how it works on FE, so I didn't change any logic here for compatibility.
Updates slider-graphql module as per this request.
In this PR: