feat/isasmendi/add scanoss.json support #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ostProcessor, implement start_line and end_line on RemoveRule
…alid settings json
eeisegn
requested changes
Dec 12, 2024
isasmendiagus
force-pushed
the
feat/isasmendi/add-scanoss.json-support
branch
from
a751c3e to
e297bac
Compare
isasmendiagus
commented
Jan 3, 2025
|
|
||
| return rules.stream() | ||
| .filter(rule -> isMatchingRule(result, rule)) | ||
| .anyMatch(rule -> { |
There was a problem hiding this comment.
@eeisegn anyMatch is a short circuit operation, the first match returns true and stops the iteration
isasmendiagus
commented
Jan 3, 2025
| private boolean isRemoveLineRangeMatch(@NonNull RemoveRule rule, @NonNull ScanFileResult result) { | ||
| LineRange ruleLineRange = new LineRange(rule.getStartLine(), rule.getEndLine()); | ||
|
|
||
| String lines = result.getFileDetails().get(0).getLines(); |
There was a problem hiding this comment.
@eeisegn Validation here is not necessary.
Invalid results are skipped upstream within hasInvalidStructure()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT