consider ASSET_DIVIDEND transactions when computing return #1
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When computing the returns of an asset, transactions of type ASSET_DIVIDEND are not considered. That makes the return rate computed by beangrow substantially different to rates reported by fund managers. I could not find any justification as to why these transactions are ignored when computing the return rates, and this seems to confuse me as well as other users. See beancount#23 and beancount#26 At least with this small patch, users get a chance to try and see if they get the result they expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing the returns of an asset, transactions of type ASSET_DIVIDEND are not considered. That makes the return rate computed by beangrow substantially different to rates reported by fund managers.
I could not find any justification as to why these transactions are ignored when computing the return rates, and this seems to confuse me as well as other users. See beancount#23 and beancount#26
At least with this small patch, users get a chance to try and see if they get the result they expected.