Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/upgrade psalm #29

Merged
merged 4 commits into from
Feb 29, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Dropping Psalm v3
Dropping Psalm v3 as PHP 7.1 support is also covered under v4.
JimTools committed Feb 29, 2024
commit cdc712284ef5ff1591c26a91e4d72089db3f4d07
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@
"squizlabs/php_codesniffer": "^3.5",
"symfony/css-selector": "^4.4|^5.0",
"symfony/dom-crawler": "^4.4|^5.0",
"vimeo/psalm": "^3.12|^4.30|^5.22"
"vimeo/psalm": "^4.30|^5.22"
},
"autoload": {
"psr-4": {

Unchanged files with check annotations Beta

*/
private $logger;
private $level;

Check failure on line 17 in src/logger/Handler/PsrLoggerHandler.php

GitHub Actions / Coding Standards - PHP 8.3

MissingPropertyType

src/logger/Handler/PsrLoggerHandler.php:17:13: MissingPropertyType: Property Scheb\Tombstone\Logger\Handler\PsrLoggerHandler::$level does not have a declared type - consider mixed (see https://psalm.dev/045)
public function __construct(LoggerInterface $logger, $level)

Check failure on line 19 in src/logger/Handler/PsrLoggerHandler.php

GitHub Actions / Coding Standards - PHP 8.3

MissingParamType

src/logger/Handler/PsrLoggerHandler.php:19:58: MissingParamType: Parameter $level has no provided type (see https://psalm.dev/154)
{
$this->logger = $logger;
$this->level = $level;