This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
scx: Replace /sys/kernel/debug/sched/ext with /sys/kernel/sched_ext #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arighi
approved these changes
Jan 18, 2024
Byte-Lab
suggested changes
Jan 18, 2024
/sys/kernel/debug/sched/ext is the current interface file which can be used to determine the current state of scx. This is problematic in that it's dependent on CONFIG_SCHED_DEBUG. On kernels which don't have the option enabled, there is no easy way to tell whether scx is currently in use. Let's add a new kobject based interface which is created under /sys/kernel/sched_ext. The directory contains: - System level interface files. As it's now a non-debug interface, confine the exposed files to "state", "switch_all" and "nr_rejected". - Per-scheduler directory which currently only contains "ops". The directory is always named "root" for now. This is in preparation of the future where there can be multiple schedulers loaded in a system. Loading and unloading of a scheduler also generates a uevent with SCXOPS attribute. Signed-off-by: Tejun Heo <[email protected]>
…w_state.py Now that the state is visible through /sys/kernel/sched_ext, /sys/kernel/debug/sched/ext isn't needed to determine the current state of scx. However, /sys/kernel/sched_ext shows only a subset of information that was available in the debug interface and it can be useful to have access to the rest for debugging. Remove /sys/kernel/debug/sched/ext and add the drgn script, tools/sched_ext/scx_show_state.py, which shows the same information. Signed-off-by: Tejun Heo <[email protected]>
Byte-Lab
approved these changes
Jan 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing state interface in /sys/kernel/debug/sched/ext is not available if CONFIG_SCHED_DEBUG is not set. Replace it with a simpler /sys/kernel/sched_ext interface and add tools/sched_ext/scx_show_state.py to keep the same level of visibility.
This will need updates in documentation and scripts in the scx repo.