fix: move navigation in hasSessionInProgress (#271)

schibsted · Apr 3, 2024 · b17a705 · b17a705
1 parent cc74052
commit b17a705
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@schibsted/account-sdk-browser",
-  "version": "4.8.7-beta.3",
+  "version": "4.8.7-beta.4",
   "description": "Schibsted account SDK for browsers",
   "main": "index.js",
   "type": "module",

diff --git a/src/identity.js b/src/identity.js
@@ -530,14 +530,12 @@ export class Identity extends EventEmitter {
                 throw err;
             }
 
-            if(sessionData){
+            if (sessionData){
                 // for expiring session and safari browser do full page redirect to gain new session
                 if(_checkRedirectionNeed(sessionData)){
                     await this.callbackBeforeRedirect();
 
-                    this.window.location.href = this._sessionService.makeUrl(sessionData.redirectURL);
-
-                    return;
+                    return this._sessionService.makeUrl(sessionData.redirectURL);
                 }
 
                 if (this._enableSessionCaching) {
@@ -552,6 +550,11 @@ export class Identity extends EventEmitter {
             .then(
                 sessionData => {
                     this._hasSessionInProgress = false;
+
+                    if (typeof sessionData === 'string' && isUrl(sessionData)) {
+                        return this.window.location.href = sessionData;
+                    }
+
                     return sessionData;
                 },
                 err => {

diff --git a/src/version.js b/src/version.js
@@ -1,5 +1,5 @@
 // Automatically generated in 'npm version' by scripts/genversion.js
 
 'use strict'
-const version = '4.8.7-beta.3';
+const version = '4.8.7-beta.4';
 export default version;