fix: code review

schibsted · Apr 15, 2024 · ff16970 · ff16970
1 parent ee69c94
commit ff16970
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/__tests__/identity.js b/__tests__/identity.js
@@ -599,10 +599,7 @@ describe('Identity', () => {
                 const MOCK_TAB_ID = 1234;
                 const spy = jest.spyOn(Identity.prototype, '_getTabId');
                 spy.mockImplementation(() => MOCK_TAB_ID);
-
-                identity = new Identity(defaultOptions);
-                identity._sessionService.fetch = getSessionMock;
-                identity._clearVarnishCookie();
+                identity._tabId = MOCK_TAB_ID;
 
                 await identity.hasSession();
 

diff --git a/src/identity.js b/src/identity.js
@@ -234,7 +234,7 @@ export class Identity extends EventEmitter {
      * Checks if getting session is blocked
      * @private
      *
-     * @returns {number}
+     * @returns {number/null}
      */
     _isSessionCallBlocked(){
         return this.localStorageCache.get(SESSION_CALL_BLOCKED_CACHE_KEY);