-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proof-of-concept: Rewrite to ts #212
base: master
Are you sure you want to change the base?
Changes from all commits
f501577
5b63fe9
7f3ca95
fb393e9
71113ab
1b717d8
b515b72
b9230d0
8fc9322
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
{ | ||
"presets": [ | ||
[ | ||
"@babel/preset-env", | ||
{ | ||
"useBuiltIns": "usage", | ||
"corejs": 3, | ||
"targets": { | ||
"browsers": [ | ||
"> 1%", | ||
"last 10 chrome major versions", | ||
"last 10 firefox major versions", | ||
"last 10 opera major versions", | ||
"last 2 safari major versions", | ||
"last 2 ios major versions", | ||
"last 2 ie major versions", | ||
"last 5 edge major versions" | ||
] | ||
} | ||
} | ||
], | ||
"@babel/preset-typescript" | ||
], | ||
"plugins": ["@babel/plugin-proposal-class-properties"] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,3 +3,4 @@ | |
coverage | ||
docs/ | ||
node_modules/ | ||
webpack.config.js |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
export {}; | ||
declare global { | ||
interface Window { | ||
openSimplifiedLoginWidget?: (initialParams: any, loginHandler: any, loginNotYouHandler: any) => void; | ||
} | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
#!/bin/bash | ||
|
||
rm -rf es5 | ||
Comment on lines
+1
to
+3
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this file is not used 🤔 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's the folder webpack use to output es5 into, so at least for now it is still used and should be cleaned I think. (This was the only non-webpack command from the old build.sh) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
/* Copyright 2018 Schibsted Products & Technology AS. Licensed under the terms of the MIT license. | ||
* See LICENSE.md in the project root. | ||
*/ | ||
|
||
export { default, Identity } from './src/identity.js'; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,5 +3,6 @@ module.exports = { | |
testPathIgnorePatterns: [ | ||
'/node_modules/', | ||
'__tests__/utils.js', | ||
'webpack.config.js', | ||
], | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to myself: we need to add eslint typescript plugin