Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move session call lock to local storage #275

Merged
merged 1 commit into from
Apr 12, 2024
Merged

move session call lock to local storage #275

merged 1 commit into from
Apr 12, 2024

Conversation

bogdan-niculescu-sch
Copy link
Collaborator

Moving sessionCallBlocked-cache to local storage to allow it to be used across bowser tabs

michal-oleniacz-stp
michal-oleniacz-stp approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@michal-oleniacz-stp michal-oleniacz-stp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have tests for the new Cache instance, but other than that LGTM

@bogdan-niculescu-sch bogdan-niculescu-sch merged commit 3e62be3 into master Apr 12, 2024
4 checks passed
@bogdan-niculescu-sch bogdan-niculescu-sch deleted the move-session-block-to-local-storage branch April 12, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michal-oleniacz-stp michal-oleniacz-stp michal-oleniacz-stp approved these changes

@hunger-programmer hunger-programmer hunger-programmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bogdan-niculescu-sch @hunger-programmer @michal-oleniacz-stp