Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to regex pub year exraction or empty string in case arrow fails to parse the date #563

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tZimmermann98
Copy link

Fixes #562

Description

When arrow fails to parse the date (due to unexisting date) it raises a ValueError. Catch this Error and fallback to regex year extraction, if no match is found an empty String is stored for pub_year.

Checklist

  • Check that the base branch is set to develop and not main.
  • Ensure that the documentation will be consistent with the code upon merging.
  • Add a line or a few lines that check the new features added.
  • Ensure that unit tests pass.
    If you don't have a premium proxy, some of the tests will be skipped.
    The tests that are run should pass without raising
    MaxTriesExceededException or other exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant