feat: allow user to safely run and manage multiple progressbar http servers #213
+63
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmsax
changed the title
|
Great work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR refactors the HTTP server implementation in the ProgressBar to address issues with the global default HTTP server instance, which caused panics when creating multiple ProgressBar instances with HTTP servers. The changes introduce a dedicated HTTP server instance for each ProgressBar, enabling users to safely run and manage multiple servers.
Key Changes:
Replaced the global http.HandleFunc with isolated http.ServeMux instances per ProgressBar.
Added a new HTTPServer object returned by StartHTTPServer(), providing a Shutdown() method for graceful termination.
Benefits:
Prevents route conflicts between multiple ProgressBar instances.
Allows users to start and stop HTTP servers independently.
Ensures safer concurrent usage and better resource management.