fix: Enforce branch protection for admins, by default #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Format and Style 🖌
|
stefanwb
force-pushed
the
enforce-admins-branch-protection
branch
2 times, most recently
from
43deba7 to
6609f8a
Compare
stefanwb
changed the title
stefanwb
force-pushed
the
enforce-admins-branch-protection
branch
from
ee7720e to
990534a
Compare
Signed-off-by: Stefan Wessels Beljaars <[email protected]>
stefanwb
force-pushed
the
enforce-admins-branch-protection
branch
from
927e372 to
3d559b5
Compare
sbp-bvanb
reviewed
Nov 11, 2024
| @@ -120,7 +120,7 @@ variable "default_branch_protection" { | |||
| })) | |||
| }) | |||
| default = { | |||
| enforce_admins = false | |||
| enforce_admins = true | |||
There was a problem hiding this comment.
Does Terraform not support constants?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the default branch protection value for
enforce_adminto true so that overriding this would be a conscious choice.