-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
white image edge detection, leads to images displayed with border #2883
Conversation
ec8cb7b
to
2958d50
Compare
oh we don't have Maybe we're still using deprecated |
OK, there's a known failure mode here, where an ALL white exclusively white image will not be detected as white-edge, because For now we're just going to postpone dealing with that -- we can manually set the metadata value on certain images if we need to. Or handle it otherwise in subsequent PR. |
…h styling in three contexts
…et have IM 7 with 'magick'
910f1c1
to
6a884b6
Compare
OK I'm gonna do border in viewer in a separate PR, so this is ready. |
OK, all white images now detected as white-edged too. |
e83d64b
to
33cd244
Compare
Replacement for #2864, ref #2491
This was pretty easy?
But it's a bit precious.... on the plus side, if it does break, it's probably just what people less picky would have had anyway? Took care of "recent items" too.
On the negative side... it actually will make our test suite slower, cause any test doing a "real" ingest with metadata extraction will run this now... our architecture doesn't give us a great way to turn it off in tests (and would we want to? not sure).
After merge/deploy
heroku run rake scihist:data_fixes:detect_white_edge WORK_FRIENDLIER_ID=jvpvngs -r production
heroku run rake scihist:data_fixes:detect_white_edge WORK_FRIENDLIER_ID=zft4n19 -r production