Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Experimental implementation of custom modifiers #1991

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

feat: Experimental implementation of custom modifiers #1991

wants to merge 17 commits into from

Commits on Oct 10, 2023

  1. add in the notebook from lukas

    @kratsg @matthewfeickert
    kratsg authored and matthewfeickert committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    6a306d3 View commit details
    Browse the repository at this point in the history

  2. Add 'experimental' extra to pyproject.toml

    @matthewfeickert
    matthewfeickert committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    dffe901 View commit details
    Browse the repository at this point in the history

  3. add is_shared

    @kratsg @matthewfeickert
    kratsg authored and matthewfeickert committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    d572c67 View commit details
    Browse the repository at this point in the history

  4. format

    @matthewfeickert
    matthewfeickert committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    c1dcf81 View commit details
    Browse the repository at this point in the history

  5. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @matthewfeickert
    pre-commit-ci[bot] authored and matthewfeickert committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    10be48a View commit details
    Browse the repository at this point in the history

  6. Apply isort

    @matthewfeickert
    matthewfeickert committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    f4f3c77 View commit details
    Browse the repository at this point in the history

  7. Make add_custom_modifier the only API and check if numexpr is installed

    @matthewfeickert
    matthewfeickert committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    d2d3497 View commit details
    Browse the repository at this point in the history

  8. Add docstrints to experimental init

    @matthewfeickert
    matthewfeickert committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    109a3c3 View commit details
    Browse the repository at this point in the history

  9. test experimental extras error if not installed

    @matthewfeickert
    matthewfeickert committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    cfad34a View commit details
    Browse the repository at this point in the history

  10. Simplify reload test

    @matthewfeickert
    matthewfeickert committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    fabdf47 View commit details
    Browse the repository at this point in the history

  11. Apply suggestion from Sourcery

    @matthewfeickert
    matthewfeickert committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    8e1c3da View commit details
    Browse the repository at this point in the history

  12. split names with with _

    @matthewfeickert
    matthewfeickert committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    c1a5f08 View commit details
    Browse the repository at this point in the history

  13. Install experimental extra in Docker image

    @matthewfeickert
    matthewfeickert committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    520df69 View commit details
    Browse the repository at this point in the history

  14. split name on _ again

    @matthewfeickert
    matthewfeickert committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    0bf30b8 View commit details
    Browse the repository at this point in the history

  15. docs: Add docstring for public method

    @matthewfeickert
    matthewfeickert committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    d9ccf67 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Add versionadded tag to docstring

    @matthewfeickert
    matthewfeickert committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    5137845 View commit details
    Browse the repository at this point in the history

  2. remove print commands (REVERT IF NEEDED FOR TESTING)

    @matthewfeickert
    matthewfeickert committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    bb302c2 View commit details
    Browse the repository at this point in the history