build: Disallow TensorFlow v2.16.1 #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tensorflow v2.16.1 breaks tensorflow-probability at import time with the Keras v3.0 API breaking change. Until Keras v3.0 is adopted in tensorflow-probability, tensorflow v2.16.1+ can't be used. - c.f. https://github.com/tensorflow/probability/issues/ 1795 * Note that Apple silicon machines should revert to installing 'tensorflow' instead of 'tensorflow-macos' for tensorflow v2.16.1+. * Note that macos x86 builds of tensorflow will be deprecated and no longer released from tensorflow v2.17.0+.
matthewfeickert
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2448 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 69 69
Lines 4539 4539
Branches 803 803
=======================================
Hits 4461 4461
Misses 45 45
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4 tasks
matthewfeickert
removed
the
need-to-backport
matthewfeickert
added a commit
that referenced
this pull request
Mar 12, 2024
…ion (#2452) * Split the requirements for the 'tensorflow' extra into two different conditional groups by python_version. - Starting with tensorflow v2.16.1, multiple changes were made that simplifies the installation of tensorflow across platform_machine and Keras v3.0 was adopted. - tensorflow-probability did _not_ adopt Keras v3.0, but instead requires tf-keras. Starting in tensorflow-probability v0.24.0 the 'tensorflow-probability[tf]' extra was added which includes all the required dependencies to be able to use tensorflow-probability with tensorflow v2.15+. - tensorflow v2.16.1 and tensorflow-probability v0.24.0 support Python 3.9+, so for Python 3.8 support the 'tensorflow' requirements need to use the previous more verbose conditionals. * Reverts PR #2448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tensorflowv2.16.1breakstensorflow-probabilityat import time with the Kerasv3.0API breaking change. Until Kerasv3.0is adopted intensorflow-probability,tensorflowv2.16.1+can't be used.3.0API tensorflow/probability#1795tensorflow v2.16.1+.tensorflow v2.17.0+.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: