Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pyodide in CI and add more tests #1365

Merged
merged 8 commits into from
Feb 27, 2025
Merged

Conversation

ariostas
Copy link
Collaborator

@ariostas ariostas commented Jan 23, 2025

I updated the version of Pyodide that is used in the CI. I'm also adding an extra test to check if AwkwardForth works properly, given that it is needed to read some RNTuple files.

@ariostas ariostas force-pushed the ariostas/update_pyodide branch from 8c3a792 to 7438a39 Compare January 23, 2025 19:30
@ariostas ariostas force-pushed the ariostas/update_pyodide branch from 7438a39 to f5d6fd9 Compare January 23, 2025 19:31
@ariostas
Copy link
Collaborator Author

This PR will have to wait until the next version of Pyodide is released (which hopefully includes the fixed awkward-cpp). Alternatively, I could change things so that awkward-cpp is built every time, but I'm not sure it's worth it.

@ariostas ariostas marked this pull request as ready for review February 26, 2025 14:37
@ariostas
Copy link
Collaborator Author

ariostas commented Feb 26, 2025

The new Pyodide 0.27.3 that was just released includes awkward-cpp 44, so now the test of RNTuple reading that uses awkward-forth pass. So this PR is now ready for review.

@ariostas ariostas requested a review from ianna February 26, 2025 14:40
Copy link
Collaborator

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariostas - Great! Looks good to me, thanks. The tests pass. Please, merge it. Thanks.

@ariostas ariostas merged commit e0f0988 into main Feb 27, 2025
26 checks passed
@ariostas ariostas deleted the ariostas/update_pyodide branch February 27, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants