-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Optional support to add c++ typenames to parameters in uproot.dask #1375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prayagyadav - Looks great, thanks! Could, please, add a test? There is a skhep_testdata
package with a number of root files already in the repository. We usually name the tests with a corresponding PR number, for example:
tests/test_0652_dask_for_awkward.py
Thanks!
@prayagyadav - we want to keep the API to use
|
Hi @ianna , sorry for the super-late reply ..... Looks like, here,
For example:
Please let me know if this makes sense. An immediate drawback of this approach, which I can think of, is that this could expose some unnecessary properties and methods to the user. |
Hi @ianna , Please let me know if this looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prayagyadav - could you, please, give me an example how it works in a non-dask case? Thanks!
@ianna Thanks! |
Optional support to add c++ typenames to parameters with ak_add_typename in uproot.dask
Necessity:
Access to C++ typename info for each tree branch is essential in building COFFEA schema for files generated with EDM4HEP.
Similar to how
ak_add_doc
is used to add the__doc__
parameter to forms,ak_add_typename
could be used to add the C++ typename of the branch in parameters.This is an attempt to solve this feature request #1369 posted by @ianna in response to the discussions among @jpivarski @ianna @davidlange6 and @prayagyadav
Outcome/Example/Expected output:
Bash:
Python:
Output:
Here is the live link to the notebook for the above example, where one can run these cells in real-time.
The bulk of the idea for these code changes was given by @davidlange6